ReverseList() instead of List.Reverse() for clear enumeration purposes

ReverseList uses backwards for, instead of true reverse

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Building/Builders/PartialIndexFilterBuilder.cs

@@ -120,8 +120,7 @@ protected override Expression VisitMemberAccess(MemberExpression originalMemberA
       }
       if (memberAccessSequence.Count==0 || !IsEntityParameter(memberAccess.Expression))
         return base.VisitMemberAccess(originalMemberAccess);
-      memberAccessSequence.Reverse();
-      var fieldName = StringExtensions.Join(".", memberAccessSequence.Select(item => item.Member.Name));
+      var fieldName = StringExtensions.Join(".", memberAccessSequence.ReverseList().Select(item => item.Member.Name));
       var field = reflectedType.Fields[fieldName];
       if (field==null)
         throw UnableToTranslate(originalMemberAccess, Strings.MemberAccessSequenceContainsNonPersistentFields);

Orm/Xtensive.Orm/Orm/Internals/SortingPersistActionGenerator.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2012 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2012-2024 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
 // Created:    2012.02.22
 
@@ -182,8 +182,7 @@ where association.OwnerField.IsEntity
       if (result.HasLoops) {
         sortedNodes = result.SortedNodes.Union(result.LoopNodes).ToList();
         var loopNodes = result.LoopNodes.ToDictionary(el => el as Collections.Graphs.Node);
-        notBreakedEdges.Reverse();
-        var loopEdgeForBreak = notBreakedEdges.First(edge => loopNodes.ContainsKey(edge.Source) && loopNodes.ContainsKey(edge.Target));
+        var loopEdgeForBreak = notBreakedEdges.ReverseList().First(edge => loopNodes.ContainsKey(edge.Source) && loopNodes.ContainsKey(edge.Target));
         result.BrokenEdges.Add(loopEdgeForBreak);
       }
       else

Orm/Xtensive.Orm/Orm/Upgrade/Internals/SqlActionTranslator.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2009-2020 Xtensive LLC.
+// Copyright (C) 2009-2024 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Ivan Galkin
@@ -845,13 +845,11 @@ private void ProcessClearAncestorsActions(List<DataAction> originalActions, bool
         if (referencedNode!=null && referencingNode!=null)
             new NodeConnection<TableInfo, ForeignKeyInfo>(referencedNode, referencingNode, foreignKey).BindToNodes();
       }
-      List<NodeConnection<TableInfo, ForeignKeyInfo>> edges;
-      var sortedTables = TopologicalSorter.Sort(nodes, out edges);
-      sortedTables.Reverse();
+      var sortedTables = TopologicalSorter.Sort(nodes, out List<NodeConnection<TableInfo, ForeignKeyInfo>> edges);
       // TODO: Process removed edges
 
       // Build DML commands
-      foreach (var table in sortedTables) {
+      foreach (var table in sortedTables.ReverseList()) {
         var tableRef = SqlDml.TableRef(FindTable(table));
         var delete = SqlDml.Delete(tableRef);
         var typeIds = deleteActions[table];