DateOnly/TimeOnly-related tests for Linq improved

Author: alex-kulakov

…fset/DateOnly/DateOnlyToIsoStringTest.cs …eOffset/DateOnly/DateOnlyToStringTest.csOrm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateOnly/DateOnlyToIsoStringTest.cs renamed to Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateOnly/DateOnlyToStringTest.cs Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateOnly/DateOnlyToIsoStringTest.cs renamed to Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateOnly/DateOnlyToStringTest.cs

@@ -11,14 +11,14 @@
 
 namespace Xtensive.Orm.Tests.Linq.DateTimeAndDateTimeOffset.DateOnlys
 {
-  public class DateOnlyToIsoStringTest : DateTimeBaseTest
+  public class DateOnlyToStringTest : DateTimeBaseTest
   {
     [Test]
-    public void ToIsoStringTest()
+    public void ToStringTest()
     {
       ExecuteInsideSession((s) => {
-        RunTest<SingleDateOnlyEntity>(s, c => c.DateOnly.ToString("s") == FirstDateOnly.ToString("s"));
-        RunWrongTest<SingleDateOnlyEntity>(s, c => c.DateOnly.ToString("s") == FirstDateOnly.AddDays(1).ToString("s"));
+        RunTest<SingleDateOnlyEntity>(s, c => c.DateOnly.ToString("o") == FirstDateOnly.ToString("o"));
+        RunWrongTest<SingleDateOnlyEntity>(s, c => c.DateOnly.ToString("o") == FirstDateOnly.AddDays(1).ToString("o"));
       });
     }
   }

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/ComparisonTestTimeOnly.cs

@@ -69,7 +69,7 @@ public void CompareMysqTest()
 
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly > FirstTimeOnly);
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly > FirstMillisecondTimeOnly);
-        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly < FirstMillisecondTimeOnly.AddMinutes(3));
+        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly < FirstMillisecondTimeOnly.AddMinutes(-3));
       });
     }
   }

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/OperationsTest.cs

@@ -17,12 +17,16 @@ public void AddHoursTest()
     {
       ExecuteInsideSession((s) => {
         RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.AddHours(1) == FirstTimeOnly.AddHours(1));
-        RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddHours(-2) == FirstMillisecondTimeOnly.AddHours(-2));
         RunTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly.Value.AddHours(33) == NullableTimeOnly.AddHours(33));
 
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.AddHours(1) == FirstTimeOnly.AddHours(2));
-        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddHours(-1) == FirstMillisecondTimeOnly.AddHours(-2));
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly.Value.AddHours(33) == NullableTimeOnly.AddHours(44));
+
+        if(StorageProviderInfo.Instance.CheckProviderIsNot(StorageProvider.MySql)
+          || StorageProviderInfo.Instance.CheckProviderVersionIsAtLeast(new Version(5, 6))) {
+          RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddHours(-2) == FirstMillisecondTimeOnly.AddHours(-2));
+          RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddHours(-1) == FirstMillisecondTimeOnly.AddHours(-2));
+        }
       });
     }
 
@@ -31,47 +35,60 @@ public void AddMinutesTest()
     {
       ExecuteInsideSession((s) => {
         RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.AddMinutes(1) == FirstTimeOnly.AddMinutes(1));
-        RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddMinutes(-2) == FirstMillisecondTimeOnly.AddMinutes(-2));
         RunTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly.Value.AddMinutes(33) == NullableTimeOnly.AddMinutes(33));
 
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.AddMinutes(1) == FirstTimeOnly.AddMinutes(2));
-        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddMinutes(-1) == FirstMillisecondTimeOnly.AddMinutes(-2));
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly.Value.AddMinutes(33) == NullableTimeOnly.AddMinutes(44));
+
+        if (StorageProviderInfo.Instance.CheckProviderIsNot(StorageProvider.MySql)
+          || StorageProviderInfo.Instance.CheckProviderVersionIsAtLeast(new Version(5, 6))) {
+          RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddMinutes(-2) == FirstMillisecondTimeOnly.AddMinutes(-2));
+          RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.AddMinutes(-1) == FirstMillisecondTimeOnly.AddMinutes(-2));
+        }
       });
     }
 
-    [Test, Ignore("Compiler's not implemented yet")]
+    [Test]
     public void AddTimeSpanTest()
     {
       ExecuteInsideSession((s) => {
-        RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.Add(FirstOffset) == FirstTimeOnly.Add(FirstOffset));
         RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.Add(SecondOffset) == FirstMillisecondTimeOnly.Add(SecondOffset));
+        RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.Add(FirstOffset) == FirstTimeOnly.Add(FirstOffset));
         RunTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly.Value.Add(FirstOffset) == NullableTimeOnly.Add(FirstOffset));
 
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.Add(FirstOffset) == FirstTimeOnly.Add(WrongOffset));
-        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.Add(SecondOffset) == FirstMillisecondTimeOnly.Add(WrongOffset));
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly.Value.Add(FirstOffset) == NullableTimeOnly.Add(WrongOffset));
+
+        if (StorageProviderInfo.Instance.CheckProviderIsNot(StorageProvider.MySql)
+          || StorageProviderInfo.Instance.CheckProviderVersionIsAtLeast(new Version(5, 6))) {
+          RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.Add(SecondOffset) == FirstMillisecondTimeOnly.Add(SecondOffset));
+          RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly.Add(SecondOffset) == FirstMillisecondTimeOnly.Add(WrongOffset));
+        }
       });
     }
 
     [Test]
     public void MinusTimeOnlyTest()
     {
-      Require.ProviderIsNot(StorageProvider.MySql);
+      var inteval = FirstTimeOnly - SecondTimeOnly;
+
       ExecuteInsideSession((s) => {
         RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly - SecondTimeOnly == FirstTimeOnly - SecondTimeOnly);
-        RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly - SecondTimeOnly == FirstMillisecondTimeOnly - SecondTimeOnly);
         RunTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly - SecondTimeOnly == NullableTimeOnly - SecondTimeOnly);
 
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly - SecondTimeOnly == FirstTimeOnly - WrongTimeOnly);
-        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly - SecondTimeOnly == FirstMillisecondTimeOnly - WrongTimeOnly);
         RunWrongTest<SingleTimeOnlyEntity>(s, c => c.NullableTimeOnly - SecondTimeOnly == NullableTimeOnly - WrongTimeOnly);
 
+        if (StorageProviderInfo.Instance.CheckProviderIsNot(StorageProvider.MySql)
+          || StorageProviderInfo.Instance.CheckProviderVersionIsAtLeast(new Version(5, 6))) {
+          RunTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly - SecondTimeOnly == FirstMillisecondTimeOnly - SecondTimeOnly);
+          RunWrongTest<SingleTimeOnlyEntity>(s, c => c.MillisecondTimeOnly - SecondTimeOnly == FirstMillisecondTimeOnly - WrongTimeOnly);
+        }
       });
     }
 
     [Test]
-    public void MysqlMinisDateTimeTest()
+    public void MysqlMinisTimeOnlyTest()
     {
       Require.ProviderIs(StorageProvider.MySql);
       ExecuteInsideSession((s) => {

…meOffset/TimeOnly/TimeOnlyToIsoString.cs …eTimeOffset/TimeOnly/TimeOnlyToString.csOrm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/TimeOnlyToIsoString.cs renamed to Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/TimeOnlyToString.cs Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/TimeOnlyToIsoString.cs renamed to Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/TimeOnlyToString.cs

@@ -11,14 +11,14 @@
 
 namespace Xtensive.Orm.Tests.Linq.DateTimeAndDateTimeOffset.TimeOnlys
 {
-  public class TimeOnlyToIsoStringTest : DateTimeBaseTest
+  public class TimeOnlyToStringTest : DateTimeBaseTest
   {
     [Test]
-    public void ToIsoStringTest()
+    public void ToStringTest()
     {
       ExecuteInsideSession((s) => {
-        RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.ToString("s") == FirstTimeOnly.ToString("s"));
-        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.ToString("s") == FirstTimeOnly.AddHours(1).ToString("s"));
+        RunTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.ToString("o") == FirstTimeOnly.ToString("o"));
+        RunWrongTest<SingleTimeOnlyEntity>(s, c => c.TimeOnly.ToString("o") == FirstTimeOnly.AddHours(1).ToString("o"));
       });
     }
   }