Extend supported ExpressionTypes by Expression visitors

Author: alex-kulakov

Orm/Xtensive.Orm/Linq/ExpressionVisitor{TResult}.cs

@@ -60,6 +60,11 @@ protected virtual TResult Visit(Expression e)
       case ExpressionType.ArrayLength:
       case ExpressionType.Quote:
       case ExpressionType.TypeAs:
+      case ExpressionType.Decrement:
+      case ExpressionType.Increment:
+      case ExpressionType.IsFalse:
+      case ExpressionType.IsTrue:
+      case ExpressionType.OnesComplement:
         result = VisitUnary((UnaryExpression) e);
         break;
       case ExpressionType.Add:
@@ -85,9 +90,12 @@ protected virtual TResult Visit(Expression e)
       case ExpressionType.RightShift:
       case ExpressionType.LeftShift:
       case ExpressionType.ExclusiveOr:
+      case ExpressionType.Power:
+      case ExpressionType.Assign:
         result = VisitBinary((BinaryExpression) e);
         break;
       case ExpressionType.TypeIs:
+      case ExpressionType.TypeEqual:
         result = VisitTypeIs((TypeBinaryExpression) e);
         break;
       case ExpressionType.Conditional:

Orm/Xtensive.Orm/Linq/Internals/ExpressionComparer.cs

@@ -51,6 +51,11 @@ private bool Visit(Expression x, Expression y)
       case ExpressionType.ArrayLength:
       case ExpressionType.Quote:
       case ExpressionType.TypeAs:
+      case ExpressionType.Decrement:
+      case ExpressionType.Increment:
+      case ExpressionType.IsFalse:
+      case ExpressionType.IsTrue:
+      case ExpressionType.OnesComplement:
         return VisitUnary((UnaryExpression) x, (UnaryExpression) y);
       case ExpressionType.Add:
       case ExpressionType.AddChecked:
@@ -75,13 +80,19 @@ private bool Visit(Expression x, Expression y)
       case ExpressionType.RightShift:
       case ExpressionType.LeftShift:
       case ExpressionType.ExclusiveOr:
+      case ExpressionType.Power:
+      case ExpressionType.Assign:
         return VisitBinary((BinaryExpression) x, (BinaryExpression) y);
       case ExpressionType.TypeIs:
         return VisitTypeIs((TypeBinaryExpression) x, (TypeBinaryExpression) y);
+      case ExpressionType.TypeEqual:
+        return VisitTypeEqual((TypeBinaryExpression) x, (TypeBinaryExpression) y);
       case ExpressionType.Conditional:
         return VisitConditional((ConditionalExpression) x, (ConditionalExpression) y);
       case ExpressionType.Constant:
         return VisitConstant((ConstantExpression) x, (ConstantExpression) y);
+      case ExpressionType.Default:
+        return true; // types and references are already compared
       case ExpressionType.Parameter:
         return VisitParameter((ParameterExpression) x, (ParameterExpression) y);
       case ExpressionType.MemberAccess:
@@ -236,6 +247,11 @@ private bool VisitTypeIs(TypeBinaryExpression x, TypeBinaryExpression y)
       return x.TypeOperand==y.TypeOperand && Visit(x.Expression, y.Expression);
     }
 
+    private bool VisitTypeEqual(TypeBinaryExpression x, TypeBinaryExpression y)
+    {
+      return x.TypeOperand == y.TypeOperand && Visit(x.Expression, y.Expression);
+    }
+
     private bool VisitBinary(BinaryExpression x, BinaryExpression y)
     {
       return x.Method==y.Method && Visit(x.Left, y.Left) && Visit(x.Right, y.Right);