PostgreSql: TimeOnly construction with hours overflow check

Author: alex-kulakov

Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/v09/Compiler.cs

@@ -517,35 +517,36 @@ protected virtual SqlExpression ConstructDate(IReadOnlyList<SqlExpression> argum
     /// <exception cref="InvalidOperationException"></exception>
     protected virtual SqlExpression ConstructTime(IReadOnlyList<SqlExpression> arguments)
     {
-      SqlExpression hour, minute, second, millisecond;
+      SqlExpression hour, minute, second, microsecond;
       if (arguments.Count == 4) {
         hour = arguments[0];
         minute = arguments[1];
         second = arguments[2];
-        millisecond = arguments[3];
+        microsecond = arguments[3] * 10000;
       }
       else if (arguments.Count == 1) {
         var ticks = arguments[0];
+        // try to optimize and reduce calculations when TimeSpan.Ticks where used for TimeOnly(ticks) ctor
+        ticks = SqlHelper.IsTimeSpanTicks(ticks, out var sourceInterval) ? sourceInterval / 100 : ticks;
         hour = SqlDml.Cast(ticks / 36000000000, SqlType.Int32);
         minute = SqlDml.Cast((ticks / 600000000) % 60, SqlType.Int32);
         second = SqlDml.Cast((ticks / 10000000) % 60, SqlType.Int32);
-        millisecond = SqlDml.Cast(ticks % 10000000, SqlType.Int32);
+        microsecond = SqlDml.Cast(ticks % 10000000, SqlType.Int32);
       }
       else {
         throw new InvalidOperationException("Unsupported count of parameters");
       }
 
-      return SqlDml.Cast(
-        DateAddMillisecond(
-          DateAddSecond(
-            DateAddMinute(
-              DateAddHour(
-                SqlDml.Literal(new TimeOnly(0, 0, 0)),
-                hour),
-              minute),
-            second),
-          millisecond),
-        SqlType.Time);
+      // Using string version of time allows to control hours overflow
+      // we cannot add hours, minutes and other parts to 00:00:00.000000 time
+      // because hours might step over 24 hours and start counting from 0.
+      // Starting from v11 built-in function with hour overflow control is used.
+      var hourString = SqlDml.Cast(hour, new SqlValueType(SqlType.VarChar, 3));
+      var minuteString = SqlDml.Cast(minute, new SqlValueType(SqlType.VarChar, 2));
+      var secondString = SqlDml.Cast(second, new SqlValueType(SqlType.VarChar, 2));
+      var microsecondString = SqlDml.Cast(microsecond, new SqlValueType(SqlType.VarChar, 7));
+      var composedTimeString = SqlDml.Concat(hourString, SqlDml.Literal(":"), minuteString, SqlDml.Literal(":"), secondString, SqlDml.Literal("."), microsecondString);
+      return SqlDml.Cast(composedTimeString, SqlType.Time);
     }
 
     /// <summary>

Orm/Xtensive.Orm.SqlServer/Sql.Drivers.SqlServer/v11/Compiler.cs

@@ -53,29 +53,31 @@ protected override SqlUserFunctionCall ConstructDateTime(IReadOnlyList<SqlExpres
     protected override SqlUserFunctionCall ConstructDate(IReadOnlyList<SqlExpression> arguments) =>
       SqlDml.FunctionCall("DATEFROMPARTS", arguments[0], arguments[1], arguments[2]);
 
-    protected override SqlUserFunctionCall ConstructTime(IReadOnlyList<SqlExpression> arguments)
+    protected override SqlExpression ConstructTime(IReadOnlyList<SqlExpression> arguments)
     {
-      SqlExpression hour, minute, second, millisecond;
+      SqlExpression hour, minute, second, microsecond;
       if (arguments.Count == 4) {
         // argument[3] * 10000 operation is based on statement that millisaconds use 3 digits
         // default precision of time is 7, and if we use raw argument[3] value the result will be .0000xxx,
         // to prevent this and make fractions part valid .xxx0000 we multiply
         hour = arguments[0];
         minute = arguments[1];
         second = arguments[2];
-        millisecond = arguments[3] * 10000;
+        microsecond = arguments[3] * 10000;
       }
       else if (arguments.Count == 1) {
         var ticks = arguments[0];
+        // try to optimize and reduce calculations when TimeSpan.Ticks where used for TimeOnly(ticks) ctor
+        ticks = SqlHelper.IsTimeSpanTicks(ticks, out var sourceInterval) ? sourceInterval / 100 : ticks;
         hour = SqlDml.Cast(ticks / 36000000000, SqlType.Int32);
         minute = SqlDml.Cast((ticks / 600000000) % 60, SqlType.Int32);
         second = SqlDml.Cast((ticks / 10000000) % 60, SqlType.Int32);
-        millisecond = SqlDml.Cast(ticks % 10000000, SqlType.Int32);
+        microsecond = SqlDml.Cast(ticks % 10000000, SqlType.Int32);
       }
       else {
         throw new InvalidOperationException("Unsupported count of parameters");
       }
-      return SqlDml.FunctionCall("TIMEFROMPARTS", hour, minute, second, millisecond, 7);
+      return SqlDml.FunctionCall("TIMEFROMPARTS", hour, minute, second, microsecond, 7);
     }
 #endif