Merge branch 'master' into master-stringoperations-imp

# Conflicts:
#	Orm/Xtensive.Orm.Tests/Storage/Providers/Sql/StringOperationsTest.cs

Author: alex-kulakov

ChangeLog/7.1.4_Z_Final.txt

@@ -0,0 +1,3 @@
+[main] Addressed IndexOutOfRangeException on translation of certain queries with aggregates
+[main] Notification to BuildLog when a hierarchy changes KeyGeneratorKind value to None
+[postgresql] Added explicit nulls setting for both column order directions to improve OrderBy/OrderByDescending performance

Orm/Xtensive.Orm.PostgreSql/Orm.Providers.PostgreSql/DomainHandler.cs

@@ -9,6 +9,7 @@
 using System.Linq;
 using Xtensive.Core;
 using Xtensive.Orm.Rse.Compilation;
+using Xtensive.Orm.Rse.Transformation;
 
 namespace Xtensive.Orm.Providers.PostgreSql
 {
@@ -21,6 +22,12 @@ public class DomainHandler : Providers.DomainHandler
     protected override ICompiler CreateCompiler(CompilerConfiguration configuration) =>
       new SqlCompiler(Handlers, configuration);
 
+    protected override IPreCompiler CreatePreCompiler(CompilerConfiguration configuration)
+    {
+      var decimalAggregateCorrector = new AggregateOverDecimalColumnCorrector(Handlers.Domain.Model);
+      return new CompositePreCompiler(decimalAggregateCorrector, base.CreatePreCompiler(configuration));
+    }
+
     /// <inheritdoc/>
     protected override IEnumerable<Type> GetProviderCompilerContainers()
     {

Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v9_0/Translator.cs

@@ -30,6 +30,9 @@ public override void Translate(SqlCompilerContext context, object literalValue)
       }
     }
 
+    public override void TranslateSortOrder(IOutput output, bool ascending) =>
+      output.Append(ascending ? "ASC NULLS FIRST" : "DESC NULLS LAST");
+
     // Constructors
 
     public Translator(SqlDriver driver)

Orm/Xtensive.Orm.Tests.Framework/AutoBuildTest.cs

@@ -18,11 +18,26 @@ namespace Xtensive.Orm.Tests
   public abstract class AutoBuildTest : HasConfigurationAccessTest
   {
     private const string ErrorInTestFixtureSetup = "Error in TestFixtureSetUp:\r\n{0}";
+    private const string ErrorNotInitializedGlobalSession = "Set InitGlobalSession to true";
+
     private DisposableSet disposables;
+    private (Session session, TransactionScope transaction) globalSessionAndTransaction;
+
+    /// <summary>
+    /// If set to <see langword="true"/>, global session and transaction will be opened
+    /// to use one session accross all test methods.
+    /// </summary>
+    protected virtual bool InitGlobalSession => false;
 
     protected ProviderInfo ProviderInfo { get; set; }
     protected Domain Domain { get; set; }
 
+    // Use these two for read-only tests only, don't change them, they are controlled by AutoBuildTest.
+    // If there is need to change Session/Transactionscope or add/modify/remove entities
+    // then open dedicated Session/TransactionScope within test
+    protected Session GlobalSession => InitGlobalSession ? globalSessionAndTransaction.session : throw new Exception(ErrorNotInitializedGlobalSession);
+    protected TransactionScope GlobalTransaction => InitGlobalSession ? globalSessionAndTransaction.transaction : throw new Exception(ErrorNotInitializedGlobalSession);
+
     [OneTimeSetUp]
     public virtual void TestFixtureSetUp()
     {
@@ -58,10 +73,16 @@ protected void RebuildDomain()
 
       var config = BuildConfiguration();
       Domain = BuildDomain(config);
-      PopulateData();
-
-      if (Domain!=null)
+      if (Domain != null) {
         ProviderInfo = Domain.StorageProviderInfo;
+        if (InitGlobalSession) {
+          globalSessionAndTransaction = CreateSessionAndTransaction();
+        }
+      }
+      else {
+        ProviderInfo = StorageProviderInfo.Instance.Info;
+      }
+      PopulateData();
     }
 
     protected virtual void PopulateData()
@@ -74,17 +95,21 @@ protected virtual void CheckRequirements()
 
     protected (Session, TransactionScope) CreateSessionAndTransaction()
     {
+      var initDisposable = disposables is null;
       try {
-        disposables = new DisposableSet();
+        if (initDisposable)
+          disposables = new DisposableSet();
         var session = Domain.OpenSession();
         var transaction = session.OpenTransaction();
         _ = disposables.Add(session);
         _ = disposables.Add(transaction);
         return (session, transaction);
       }
       catch {
-        disposables.DisposeSafely();
-        disposables = null;
+        if (initDisposable) {
+          disposables.DisposeSafely();
+          disposables = null;
+        }
         throw;
       }
     }

Orm/Xtensive.Orm.Tests.Framework/Internals/KeyValuePairInstanceGenerator.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
+// Copyright (C) 2003-2010 Xtensive LLC.
 // All rights reserved.
 // For conditions of distribution and use, see license.
 // Created by: Alex Yakunin
@@ -13,13 +13,13 @@ namespace Xtensive.Orm.Tests
   [Serializable]
   internal class ArrayInstanceGenerator<T>: WrappingInstanceGenerator<T[], T>
   {
-    public const int ArrayLenght = 100;
+    public const int ArrayLength = 100;
 
     public override T[] GetInstance(Random random)
     {
-      T[] result = new T[ArrayLenght];
+      T[] result = new T[ArrayLength];
       int i = 0;
-      foreach (T t in BaseGenerator.GetInstances(random, ArrayLenght)) {
+      foreach (T t in BaseGenerator.GetInstances(random, ArrayLength)) {
         result[i] = t;
         i++;
       }