Better names for tests of Microsoft.Extensions.Configuration-based config loading

alex-kulakov · alex-kulakov · commit aae811429311 · 2024-10-03T16:14:41.000+05:00
diff --git a/Extensions/TestCommon/ModernConfigurationTestBase.cs b/Extensions/TestCommon/ModernConfigurationTestBase.cs
@@ -9,7 +9,7 @@
 
 namespace TestCommon
 {
-  public abstract class ModernConfigurationTestBase
+  public abstract class MicrosoftConfigurationTestBase
   {
     protected enum ConfigTypes
     {
diff --git a/Extensions/Xtensive.Orm.Localization.Tests/MicrosoftConfigurationTests.cs b/Extensions/Xtensive.Orm.Localization.Tests/MicrosoftConfigurationTests.cs
@@ -10,7 +10,7 @@
 
 namespace Xtensive.Orm.Localization.Tests.Configuration
 {
-  public sealed class JsonConfigurationTest : ModernConfigurationTest
+  public sealed class JsonConfigurationTest : MicrosoftConfigurationTest
   {
     protected override ConfigTypes ConfigFormat => ConfigTypes.Json;
 
@@ -20,7 +20,7 @@ protected override void AddConfigurationFile(IConfigurationBuilder configuration
     }
   }
 
-  public sealed class XmlConfigurationTest : ModernConfigurationTest
+  public sealed class XmlConfigurationTest : MicrosoftConfigurationTest
   {
     protected override ConfigTypes ConfigFormat => ConfigTypes.Xml;
 
@@ -98,7 +98,7 @@ public void NameAttributePascalCase(bool useRoot)
   }
 
   [TestFixture]
-  public abstract class ModernConfigurationTest : TestCommon.ModernConfigurationTestBase
+  public abstract class MicrosoftConfigurationTest : TestCommon.MicrosoftConfigurationTestBase
   {
     protected readonly CultureInfo defaultCulture = new CultureInfo("en-US");
     protected readonly CultureInfo expectedCulture = new CultureInfo("es-ES");
diff --git a/Extensions/Xtensive.Orm.Reprocessing.Tests/Tests/MicrosoftConfugurationTests.cs b/Extensions/Xtensive.Orm.Reprocessing.Tests/Tests/MicrosoftConfugurationTests.cs
@@ -9,7 +9,7 @@
 
 namespace Xtensive.Orm.Reprocessing.Tests.Configuration
 {
-  public sealed class JsonConfigurationTest : ModernConfigurationTest
+  public sealed class JsonConfigurationTest : MicrosoftConfigurationTest
   {
     protected override ConfigTypes ConfigFormat => ConfigTypes.Json;
 
@@ -19,7 +19,7 @@ protected override void AddConfigurationFile(IConfigurationBuilder configuration
     }
   }
 
-  public sealed class XmlConfigurationTest : ModernConfigurationTest
+  public sealed class XmlConfigurationTest : MicrosoftConfigurationTest
   {
     protected override ConfigTypes ConfigFormat => ConfigTypes.Xml;
 
@@ -131,7 +131,7 @@ public void AttributesInPascalCase(bool useRoot)
     }
   }
 
-  public abstract class ModernConfigurationTest : TestCommon.ModernConfigurationTestBase
+  public abstract class MicrosoftConfigurationTest : TestCommon.MicrosoftConfigurationTestBase
   {
     protected ReprocessingConfiguration LoadConfiguration(string sectionName, bool useRoot)
     {
diff --git a/Extensions/Xtensive.Orm.Security.Tests/Tests/MicrosoftConfigurationTests.cs b/Extensions/Xtensive.Orm.Security.Tests/Tests/MicrosoftConfigurationTests.cs
@@ -8,7 +8,7 @@
 
 namespace Xtensive.Orm.Security.Tests.Configuration
 {
-  public sealed class JsonConfigurationTests : ModernConfigurationTests
+  public sealed class JsonConfigurationTests : MicrosoftConfigurationTests
   {
     protected override ConfigTypes ConfigFormat => ConfigTypes.Json;
 
@@ -18,7 +18,7 @@ protected override void AddConfigurationFile(IConfigurationBuilder configuration
     }
   }
 
-  public sealed class XmlConfigurationTests : ModernConfigurationTests
+  public sealed class XmlConfigurationTests : MicrosoftConfigurationTests
   {
     protected override ConfigTypes ConfigFormat => ConfigTypes.Xml;
 
@@ -123,7 +123,7 @@ public void NameAttributePascalCaseTest(bool useRoot)
 
 
   [TestFixture]
-  public abstract class ModernConfigurationTests : TestCommon.ModernConfigurationTestBase
+  public abstract class MicrosoftConfigurationTests : TestCommon.MicrosoftConfigurationTestBase
   {
     protected SecurityConfiguration LoadConfiguration(string sectionName, bool useRoot)
     {
diff --git a/Orm/Xtensive.Orm.Tests/Configuration/MicrosoftConfigurationTests.cs b/Orm/Xtensive.Orm.Tests/Configuration/MicrosoftConfigurationTests.cs
@@ -72,7 +72,7 @@ public class DummyEntity3 : Entity
 namespace Xtensive.Orm.Tests.Configuration
 {
   [TestFixture]
-  public sealed class AppConfigStyleConfigurationTest : ConfigurationFileTestBase
+  public sealed class AppConfigStyleConfigurationTest : MicrosoftConfigurationTestBase
   {
     protected override string Postfix => "AppConfig";
 
@@ -85,7 +85,7 @@ protected override void RegisterConfigurationFile(ConfigurationBuilder builder)
   }
 
   [TestFixture]
-  public sealed class XmlConfigurationTest : ConfigurationFileTestBase
+  public sealed class XmlConfigurationTest : MicrosoftConfigurationTestBase
   {
     protected override string Postfix => "Xml";
 
@@ -96,7 +96,7 @@ protected override void RegisterConfigurationFile(ConfigurationBuilder builder)
   }
 
   [TestFixture]
-  public sealed class JsonConfigurationTest : ConfigurationFileTestBase
+  public sealed class JsonConfigurationTest : MicrosoftConfigurationTestBase
   {
     protected override string Postfix => "Json";
 
@@ -106,13 +106,11 @@ protected override void RegisterConfigurationFile(ConfigurationBuilder builder)
     }
   }
 
-  public abstract class ConfigurationFileTestBase
+  public abstract class MicrosoftConfigurationTestBase
   {
-
     private IConfigurationRoot configuration;
     private IConfigurationSection configurationSection;
 
-    
     protected abstract string Postfix { get; }
     protected virtual bool NameAttributeUnique => true;
 

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`namespace TestCommon`
`11`	`11`	`{`
`12`		`- public abstract class ModernConfigurationTestBase`
	`12`	`+ public abstract class MicrosoftConfigurationTestBase`
`13`	`13`	`{`
`14`	`14`	`protected enum ConfigTypes`
`15`	`15`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`namespace Xtensive.Orm.Localization.Tests.Configuration`
`12`	`12`	`{`
`13`		`- public sealed class JsonConfigurationTest : ModernConfigurationTest`
	`13`	`+ public sealed class JsonConfigurationTest : MicrosoftConfigurationTest`
`14`	`14`	`{`
`15`	`15`	`protected override ConfigTypes ConfigFormat => ConfigTypes.Json;`
`16`	`16`
`@@ -20,7 +20,7 @@ protected override void AddConfigurationFile(IConfigurationBuilder configuration`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`
`23`		`- public sealed class XmlConfigurationTest : ModernConfigurationTest`
	`23`	`+ public sealed class XmlConfigurationTest : MicrosoftConfigurationTest`
`24`	`24`	`{`
`25`	`25`	`protected override ConfigTypes ConfigFormat => ConfigTypes.Xml;`
`26`	`26`
`@@ -98,7 +98,7 @@ public void NameAttributePascalCase(bool useRoot)`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`[TestFixture]`
`101`		`- public abstract class ModernConfigurationTest : TestCommon.ModernConfigurationTestBase`
	`101`	`+ public abstract class MicrosoftConfigurationTest : TestCommon.MicrosoftConfigurationTestBase`
`102`	`102`	`{`
`103`	`103`	`protected readonly CultureInfo defaultCulture = new CultureInfo("en-US");`
`104`	`104`	`protected readonly CultureInfo expectedCulture = new CultureInfo("es-ES");`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`namespace Xtensive.Orm.Security.Tests.Configuration`
`10`	`10`	`{`
`11`		`- public sealed class JsonConfigurationTests : ModernConfigurationTests`
	`11`	`+ public sealed class JsonConfigurationTests : MicrosoftConfigurationTests`
`12`	`12`	`{`
`13`	`13`	`protected override ConfigTypes ConfigFormat => ConfigTypes.Json;`
`14`	`14`
`@@ -18,7 +18,7 @@ protected override void AddConfigurationFile(IConfigurationBuilder configuration`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`
`21`		`- public sealed class XmlConfigurationTests : ModernConfigurationTests`
	`21`	`+ public sealed class XmlConfigurationTests : MicrosoftConfigurationTests`
`22`	`22`	`{`
`23`	`23`	`protected override ConfigTypes ConfigFormat => ConfigTypes.Xml;`
`24`	`24`
`@@ -123,7 +123,7 @@ public void NameAttributePascalCaseTest(bool useRoot)`
`123`	`123`
`124`	`124`
`125`	`125`	`[TestFixture]`
`126`		`- public abstract class ModernConfigurationTests : TestCommon.ModernConfigurationTestBase`
	`126`	`+ public abstract class MicrosoftConfigurationTests : TestCommon.MicrosoftConfigurationTestBase`
`127`	`127`	`{`
`128`	`128`	`protected SecurityConfiguration LoadConfiguration(string sectionName, bool useRoot)`
`129`	`129`	`{`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public class DummyEntity3 : Entity`
`72`	`72`	`namespace Xtensive.Orm.Tests.Configuration`
`73`	`73`	`{`
`74`	`74`	`[TestFixture]`
`75`		`- public sealed class AppConfigStyleConfigurationTest : ConfigurationFileTestBase`
	`75`	`+ public sealed class AppConfigStyleConfigurationTest : MicrosoftConfigurationTestBase`
`76`	`76`	`{`
`77`	`77`	`protected override string Postfix => "AppConfig";`
`78`	`78`
`@@ -85,7 +85,7 @@ protected override void RegisterConfigurationFile(ConfigurationBuilder builder)`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`[TestFixture]`
`88`		`- public sealed class XmlConfigurationTest : ConfigurationFileTestBase`
	`88`	`+ public sealed class XmlConfigurationTest : MicrosoftConfigurationTestBase`
`89`	`89`	`{`
`90`	`90`	`protected override string Postfix => "Xml";`
`91`	`91`
`@@ -96,7 +96,7 @@ protected override void RegisterConfigurationFile(ConfigurationBuilder builder)`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`[TestFixture]`
`99`		`- public sealed class JsonConfigurationTest : ConfigurationFileTestBase`
	`99`	`+ public sealed class JsonConfigurationTest : MicrosoftConfigurationTestBase`
`100`	`100`	`{`
`101`	`101`	`protected override string Postfix => "Json";`
`102`	`102`
`@@ -106,13 +106,11 @@ protected override void RegisterConfigurationFile(ConfigurationBuilder builder)`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`109`		`- public abstract class ConfigurationFileTestBase`
	`109`	`+ public abstract class MicrosoftConfigurationTestBase`
`110`	`110`	`{`
`111`		`-`
`112`	`111`	`private IConfigurationRoot configuration;`
`113`	`112`	`private IConfigurationSection configurationSection;`
`114`	`113`
`115`		`-`
`116`	`114`	`protected abstract string Postfix { get; }`
`117`	`115`	`protected virtual bool NameAttributeUnique => true;`
`118`	`116`