QueryTranslationResult moves List creation to the caller

this allows to create List more efficiently

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Services/QueryBuilding/QueryBuilder.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2012-2020 Xtensive LLC.
+// Copyright (C) 2012-2020 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
@@ -47,9 +47,14 @@ public QueryTranslationResult TranslateQuery<TResult>(IQueryable<TResult> query)
 
       var request = sqlProvider.Request;
 
-      return new QueryTranslationResult(
-        request.Statement,
-        request.ParameterBindings.Select(b => new QueryParameterBinding(b)));
+      if (request.ParameterBindings is ICollection<Providers.QueryParameterBinding> bindingCollection) {
+        return new QueryTranslationResult(
+          request.Statement,
+          bindingCollection.SelectToList(b => new QueryParameterBinding(b)));
+      }
+      else
+        return new QueryTranslationResult(request.Statement,
+          request.ParameterBindings.Select(b => new QueryParameterBinding(b)).ToList());
     }
 
     /// <summary>

Orm/Xtensive.Orm/Orm/Services/QueryBuilding/QueryTranslationResult.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2012 Xtensive LLC.
+// Copyright (C) 2012 Xtensive LLC.
 // All rights reserved.
 // For conditions of distribution and use, see license.
 // Created by: Denis Krjuchkov
@@ -27,10 +27,10 @@ public sealed class QueryTranslationResult
 
     // Constructors
 
-    internal QueryTranslationResult(ISqlCompileUnit query, IEnumerable<QueryParameterBinding> bindings)
+    internal QueryTranslationResult(ISqlCompileUnit query, IList<QueryParameterBinding> bindings)
     {
       Query = query;
-      ParameterBindings = bindings.ToList();
+      ParameterBindings = bindings;
     }
   }
 }