Mysql: No support for TimeConstruct operation

There is no way to control hours overflow, Even MAKETIME function
returns NULL or max value if value is incorrect, this opens way to
possibly corrupted query results which is bad

Author: alex-kulakov

Orm/Xtensive.Orm.MySql/Sql.Drivers.MySql/v5_0/Compiler.cs

@@ -24,13 +24,6 @@ internal class Compiler : SqlCompiler
     protected const long NanosecondsPerMicrosecond = 1000;
     protected const long MillisecondsPerDay = 86400000;
 
-    //protected static readonly long NanosecondsPerDay = TimeSpan.FromDays(1).Ticks * 100;
-    //protected static readonly long NanosecondsPerSecond = 1000000000;
-    //protected static readonly long NanosecondsPerMillisecond = 1000000;
-    //protected static readonly long NanosecondsPerMicrosecond = 1000;
-    //protected static readonly long MillisecondsPerDay = (long) TimeSpan.FromDays(1).TotalMilliseconds;
-    //protected static readonly long MillisecondsPerSecond = 1000L;
-
     /// <inheritdoc/>
     public override void Visit(SqlSelect node)
     {
@@ -222,9 +215,6 @@ public override void Visit(SqlFunctionCall node)
                 SqlDml.RawConcat(SqlDml.Native("INTERVAL "), SqlDml.FunctionCall("TIME_TO_SEC", arguments[0]) + arguments[1] * 60),
                 SqlDml.Native("SECOND")))));
           return;
-        case SqlFunctionType.TimeConstruct:
-          ConstructTime(arguments).AcceptVisitor(this);
-          return;
         case SqlFunctionType.TimeToNanoseconds:
           TimeToNanoseconds(arguments[0]).AcceptVisitor(this);
           return;
@@ -341,38 +331,6 @@ protected virtual SqlExpression ConstructDate(IReadOnlyList<SqlExpression> argum
         arguments[2] - 1);
     }
 
-    protected virtual SqlExpression ConstructTime(IReadOnlyList<SqlExpression> arguments)
-    {
-      SqlExpression hour, minute, second, millisecond;
-      if (arguments.Count == 4) {
-        hour = arguments[0];
-        minute = arguments[1];
-        second = arguments[2];
-        millisecond = arguments[3];
-      }
-      else if (arguments.Count == 1) {
-        var ticks = arguments[0];
-        hour = SqlDml.Cast(ticks / 36000000000, SqlType.Int32);
-        minute = SqlDml.Cast((ticks / 600000000) % 60, SqlType.Int32);
-        second = SqlDml.Cast((ticks / 10000000) % 60, SqlType.Int32);
-        millisecond = 0; //SqlDml.Cast((ticks % 10000000) / 10, SqlType.Int32);
-      }
-      else {
-        throw new InvalidOperationException("Unsupported count of parameters");
-      }
-
-      return SqlDml.FunctionCall("TIME",
-        TimeAddMillisecond(
-          TimeAddSecond(
-            TimeAddMinute(
-              TimeAddHour(
-                SqlDml.Literal(new DateTime(2001, 1, 1)),
-                hour),
-              minute),
-            second),
-          millisecond));
-    }
-
     protected virtual SqlExpression TimeToNanoseconds(SqlExpression time)
     {
       var nPerHour = SqlDml.Extract(SqlTimePart.Hour, time) * NanosecondsPerHour;

Orm/Xtensive.Orm.MySql/Sql.Drivers.MySql/v5_6/Compiler.cs

@@ -61,40 +61,6 @@ protected override SqlBinary TimeSubtractTime(SqlExpression time1, SqlExpression
       SqlDml.Modulo(
         NanosecondsPerDay + CastToDecimal(DateTimeDiffMicrosecond(time2, time1), 18, 0) * NanosecondsPerMicrosecond,
         NanosecondsPerDay);
-
-    protected override SqlUserFunctionCall ConstructTime(IReadOnlyList<SqlExpression> arguments)
-    {
-      SqlExpression hour, minute, second, millisecond;
-      if (arguments.Count == 4) {
-        hour = arguments[0];
-        minute = arguments[1];
-        second = arguments[2];
-        millisecond = arguments[3];
-      }
-      else if (arguments.Count == 1) {
-        var ticks = arguments[0];
-        if (SqlHelper.IsTimeSpanTicks(ticks, out var sourceInterval)) {
-          hour = SqlDml.Cast(ticks / 36000000000, SqlType.Int32);
-          minute = SqlDml.Cast((ticks / 600000000) % 60, SqlType.Int32);
-          second = SqlDml.Cast((ticks / 10000000) % 60, SqlType.Int32);
-          millisecond = SqlDml.Cast((ticks % 10000000) / 10, SqlType.Int32) / 1000;
-        }
-        else {
-          hour = SqlDml.Cast(ticks / 36000000000, SqlType.Int32);
-          minute = SqlDml.Cast((ticks / 600000000) % 60, SqlType.Int32);
-          second = SqlDml.Cast((ticks / 10000000) % 60, SqlType.Int32);
-          millisecond = SqlDml.Cast((ticks % 10000000) / 10, SqlType.Int32) / 1000;
-        }
-      }
-      else {
-        throw new InvalidOperationException("Unsupported count of parameters");
-      }
-      return MakeTime(hour, minute, second, millisecond);
-    }
-
-    protected SqlUserFunctionCall MakeTime(
-        SqlExpression hours, SqlExpression minutes, SqlExpression seconds, SqlExpression milliseconds) =>
-      SqlDml.FunctionCall("MAKETIME", hours, minutes, seconds + (milliseconds / 1000));
 #endif
 
     // Constructors

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/TimeOnly/ConstructorTest.cs

@@ -107,31 +107,6 @@ public void CtorTicksFromIntervalTicks()
       });
     }
 
-    [Test]
-    public void MysqlCtorTicksFromIntervalTicks()
-    {
-      Require.ProviderIs(StorageProvider.MySql);
-
-      if (StorageProviderInfo.Instance.Info.StorageVersion <= StorageProviderVersion.MySql55) {
-        ExecuteInsideSession((s) => {
-          var result = s.Query.All<AllPossiblePartsEntity>()
-            .Select(e => new { Entity = e, ConstructedTime = new TimeOnly(e.TimeSpan.Ticks) })
-            .Where(a => a.ConstructedTime == FirstTimeOnly)
-            .OrderBy(a => a.Entity.Id).ToList(3);
-          Assert.That(result.Count, Is.EqualTo(1));
-        });
-      }
-      else {
-        ExecuteInsideSession((s) => {
-          var result = s.Query.All<AllPossiblePartsEntity>()
-            .Select(e => new { Entity = e, ConstructedTime = new TimeOnly(e.TimeSpan.Ticks) })
-            .Where(a => a.ConstructedTime == FirstMillisecondTimeOnly)
-            .OrderBy(a => a.Entity.Id).ToList(3);
-          Assert.That(result.Count, Is.EqualTo(1));
-        });
-      }
-    }
-
     [Test]
     public void TicksFromColumnsBasedExpression()
     {