Code formatting changes

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Linq/Translator.Expressions.cs

@@ -55,13 +55,13 @@ protected override Expression VisitTypeIs(TypeBinaryExpression tb)
 
       // Structure
       var memberType = expression.GetMemberType();
-      if (memberType==MemberType.Structure
+      if (memberType == MemberType.Structure
         && WellKnownOrmTypes.Structure.IsAssignableFrom(operandType)) {
         return FalseExpression;
       }
 
       // Entity
-      if (memberType==MemberType.Entity
+      if (memberType == MemberType.Entity
         && WellKnownOrmInterfaces.Entity.IsAssignableFrom(operandType)) {
         TypeInfo type = context.Model.Types[operandType];
 

Orm/Xtensive.Orm/Orm/Providers/SqlCompiler.Index.cs

@@ -134,7 +134,7 @@ private QueryAndBindings BuildJoinQuery(IndexInfo index)
       var keyColumnCount = index.KeyColumns.Count;
       var underlyingQueries = index.UnderlyingIndexes.Select(BuildProviderQuery);
 
-      var sourceTables = new List<SqlTable>();
+      var sourceTables = new List<SqlTable>(index.UnderlyingIndexes.Count);
       List<QueryParameterBinding> resultBindings = null;
       if(index.UnderlyingIndexes.Any(i => i.IsVirtual)) {
         foreach(var item in underlyingQueries) {

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/AggregateProvider.cs

@@ -137,7 +137,7 @@ private static Type GetMinMaxColumnType(Type sourceColumnType, AggregateType agg
         if (sourceColumnType == WellKnownTypes.DateOnly || sourceColumnType == WellKnownTypes.TimeOnly)
           return sourceColumnType;
 #endif
-          throw AggregateNotSupported(sourceColumnType, aggregateType);
+        throw AggregateNotSupported(sourceColumnType, aggregateType);
       }
     }
 

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/ContainsTableProvider.cs

@@ -53,8 +53,7 @@ public ContainsTableProvider(FullTextIndexInfo index, Func<ParameterContext, str
       SearchCriteria = searchCriteria;
       FullFeatured = fullFeatured;
       PrimaryIndex = new IndexInfoRef(index.PrimaryIndex);
-      TargetColumns = targetColumns.Select(tc => index.Columns.First(c => c.Column == tc))
-        .ToList(targetColumns.Count)
+      TargetColumns = targetColumns.SelectToList(tc => index.Columns.First(c => c.Column == tc))
         .AsReadOnly();
       TopN = topNByRank;
       if (FullFeatured) {
@@ -68,12 +67,12 @@ public ContainsTableProvider(FullTextIndexInfo index, Func<ParameterContext, str
         if (primaryIndexKeyColumns.Count!=1)
           throw new InvalidOperationException(Strings.ExOnlySingleColumnKeySupported);
         var fieldTypes = primaryIndexKeyColumns
-          .Select(columnInfo => columnInfo.Key.ValueType)
+          .Select(static columnInfo => columnInfo.Key.ValueType)
           .Append(WellKnownTypes.Double)
           .ToArray(primaryIndexKeyColumns.Count + 1);
         var tupleDescriptor = TupleDescriptor.Create(fieldTypes);
         var columns = primaryIndexKeyColumns
-          .Select((c, i) => (Column) new MappedColumn("KEY", i, c.Key.ValueType))
+          .Select(static (c, i) => (Column) new MappedColumn("KEY", i, c.Key.ValueType))
           .Append(new MappedColumn("RANK", tupleDescriptor.Count, WellKnownTypes.Double))
           .ToArray(primaryIndexKeyColumns.Count + 1);;
         indexHeader = new RecordSetHeader(tupleDescriptor, columns);

Orm/Xtensive.Orm/Orm/Rse/Providers/Compilable/FreeTextProvider.cs

@@ -61,12 +61,12 @@ public FreeTextProvider(
         if (primaryIndexKeyColumns.Count!=1)
           throw new InvalidOperationException(Strings.ExOnlySingleColumnKeySupported);
         var fieldTypes = primaryIndexKeyColumns
-          .Select(columnInfo => columnInfo.Key.ValueType)
+          .Select(static columnInfo => columnInfo.Key.ValueType)
           .Append(WellKnownTypes.Double)
           .ToArray(primaryIndexKeyColumns.Count + 1);
         var tupleDescriptor = TupleDescriptor.Create(fieldTypes);
         var columns = primaryIndexKeyColumns
-          .Select((c, i) => (Column) new MappedColumn("KEY", i, c.Key.ValueType))
+          .Select(static (c, i) => (Column) new MappedColumn("KEY", i, c.Key.ValueType))
           .Append(new MappedColumn("RANK", tupleDescriptor.Count, WellKnownTypes.Double))
           .ToArray(primaryIndexKeyColumns.Count + 1);
         indexHeader = new RecordSetHeader(tupleDescriptor, columns);

Orm/Xtensive.Orm/Orm/Rse/RecordSetHeader.cs

@@ -287,7 +287,9 @@ private static RecordSetHeader CreateHeader(IndexInfo indexInfo)
         .SelectToArray(static columnInfo => columnInfo.Key.ValueType);
       var keyDescriptor = TupleDescriptor.Create(keyFieldTypes);
 
-      var resultColumns = indexInfoColumns.Select((c,i) => (Column) new MappedColumn(new ColumnInfoRef(c), i,c.ValueType)).ToArray(indexInfoColumns.Count);
+      var resultColumns = indexInfoColumns
+        .Select(static (c,i) => (Column) new MappedColumn(new ColumnInfoRef(c), i, c.ValueType))
+        .ToArray(indexInfoColumns.Count);
       var resultGroups = new[]{indexInfo.Group};
 
       return new RecordSetHeader(

Orm/Xtensive.Orm/Orm/Rse/Transformation/Internals/ApplyPredicateCollector.cs

@@ -67,12 +67,13 @@ public void ValidateSelectedColumnIndexes(SelectProvider provider)
 
     private void SaveApplyPredicate(FilterProvider filter, ApplyParameter applyParameter)
     {
+      var providerAndFilterColumns = (filter.Predicate, filter.Header.Columns);
       if (owner.State.Predicates.TryGetValue(applyParameter, out var predicates)) {
-        predicates.Add((filter.Predicate, filter.Header.Columns));
+        predicates.Add(providerAndFilterColumns);
       }
       else {
         owner.State.Predicates.Add(applyParameter,
-          new List<(Expression<Func<Tuple, bool>>, ColumnCollection)> { (filter.Predicate, filter.Header.Columns) });
+          new List<(Expression<Func<Tuple, bool>>, ColumnCollection)> { providerAndFilterColumns });
       }
     }
 

Orm/Xtensive.Orm/Orm/Rse/Transformation/Internals/ApplyProviderCorrectorRewriter.cs

@@ -322,7 +322,7 @@ private void VisitBinaryProvider(BinaryProvider provider,
     private Provider ProcesSelfConvertibleApply(ApplyProvider provider, CompilableProvider left,
       CompilableProvider right)
     {
-      State.Predicates.Remove(provider.ApplyParameter);
+      _ = State.Predicates.Remove(provider.ApplyParameter);
       if (left != provider.Left || right != provider.Right)
         return new ApplyProvider(provider.ApplyParameter, left, right, provider.IsInlined, provider.SequenceType, provider.ApplyType);
       return provider;

Orm/Xtensive.Orm/Sql/Compiler/Internals/PostCompiler.cs

@@ -84,7 +84,7 @@ public override void Visit(CycleNode node)
       for (int i = 0, count = items.Count; i < count - 1; i++) {
         currentCycleItem = items[i];
         VisitNodes(node.Body);
-        result.Append(node.Delimiter);
+        _ = result.Append(node.Delimiter);
       }
       currentCycleItem = items[items.Count - 1];
       VisitNodes(node.Body);