Some tricky operations with datetime fractions changed

Only tests affected

Author: alex-kulakov

Orm/Xtensive.Orm.Tests.Framework/TestHelper.cs

@@ -67,9 +67,8 @@ public static DateTime AdjustDateTimeForCurrentProvider(this DateTime origin)
     /// <param name="origin">The value to adjust.</param>
     /// <param name="providerInfo">Type of provider.</param>
     /// <returns>New value with less resolution if the provider requires it, otherwise, untouched <paramref name="origin"/>.</returns>
-    private static DateTime AdjustDateTimeForProvider(this DateTime origin, StorageProviderInfo providerInfo)
+    public static DateTime AdjustDateTimeForProvider(this DateTime origin, StorageProviderInfo providerInfo)
     {
-      //long? divider;
       var provider = providerInfo.Provider;
       switch (provider) {
         case StorageProvider.MySql:
@@ -81,7 +80,7 @@ private static DateTime AdjustDateTimeForProvider(this DateTime origin, StorageP
         case StorageProvider.PostgreSql:
           return AdjustDateTime(origin, 6);
         case StorageProvider.Oracle:
-          return AdjustDateTime(origin, 6, true);
+          return AdjustDateTime(origin, 7);
         default:
           return origin;
       }
@@ -91,11 +90,11 @@ private static DateTime AdjustDateTimeForProvider(this DateTime origin, StorageP
     /// Cuts down fractions of <see cref="DateTime"/> value (nanoseconds, milliseconds, etc) to desired value.
     /// </summary>
     /// <param name="origin"></param>
-    /// <param name="desiredFractions">Number of fractional points to keep.</param>
+    /// <param name="desiredFractions">Number of fractional points to keep (from 0 to 7).</param>
     /// <param name="requireRound">Indicates whether value should be rounded after cutting off.</param>
     /// <returns>Result value.</returns>
     /// <exception cref="ArgumentOutOfRangeException">Valid fractions should be between 0 and 7 (7 included).</exception>
-    public static DateTime AdjustDateTime(this DateTime origin, byte desiredFractions = 7, bool requireRound = false)
+    public static DateTime AdjustDateTime(this DateTime origin, byte desiredFractions, bool requireRound = false)
     {
       if (desiredFractions == 7) {
         return origin;

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateTime/OperationsTest.cs

@@ -192,14 +192,14 @@ public void MinusDateTimeTest()
     }
 
     [Test]
-    public void MysqlMinisDateTimeTest()
+    public void MysqlMinusDateTimeTest()
     {
       Require.ProviderIs(StorageProvider.MySql);
       ExecuteInsideSession(() => {
-        var firstDateTime = FirstDateTime.AdjustDateTimeForCurrentProvider();
-        var firstMillisecondDateTime = FirstMillisecondDateTime.AdjustDateTimeForCurrentProvider();
-        var secondDateTime = SecondDateTime.AdjustDateTimeForCurrentProvider();
-        var nullableDateTime = NullableDateTime.AdjustDateTimeForCurrentProvider();
+        var firstDateTime = FirstDateTime.AdjustDateTime(0);
+        var firstMillisecondDateTime = FirstMillisecondDateTime.AdjustDateTime(0);
+        var secondDateTime = SecondDateTime.AdjustDateTime(0);
+        var nullableDateTime = NullableDateTime.AdjustDateTime(0);
 
         RunTest<SingleDateTimeEntity>(c => c.DateTime - secondDateTime == firstDateTime - secondDateTime);
         RunTest<SingleDateTimeEntity>(c => c.MillisecondDateTime - secondDateTime == firstMillisecondDateTime - secondDateTime);

Orm/Xtensive.Orm.Tests/Linq/DateTimeAndDateTimeOffset/DateTime/PartsExtractionTest.cs

@@ -111,7 +111,7 @@ public void MysqlExtractMillisecondTest()
     {
       Require.ProviderIs(StorageProvider.MySql);
       ExecuteInsideSession((s) => {
-        var firstMillisecondDateTime = FirstMillisecondDateTime.AdjustDateTimeForCurrentProvider();
+        var firstMillisecondDateTime = FirstMillisecondDateTime.AdjustDateTime(0);
         RunTest<SingleDateTimeEntity>(s, c => c.MillisecondDateTime.Millisecond == firstMillisecondDateTime.Millisecond);
         RunWrongTest<SingleDateTimeEntity>(s, c => c.MillisecondDateTime.Second == WrongMillisecondDateTime.Millisecond);
       });

Orm/Xtensive.Orm.Tests/Storage/DateTimeStoragePrecisionTest.cs

@@ -92,9 +92,14 @@ public void TimeOnlyTest()
     private static TimeOnly GetExpectedValue(in TimeOnly baseTimeOnly) => baseTimeOnly.AdjustTimeOnlyForCurrentProvider();
 
 #endif
-    private static DateTime GetExpectedValue(in DateTime baseDateTime) =>
-      StorageProviderInfo.Instance.Provider == StorageProvider.MySql
+    private static DateTime GetExpectedValue(in DateTime baseDateTime)
+    {
+      var provider = StorageProviderInfo.Instance.Provider;
+      return provider == StorageProvider.MySql
         ? baseDateTime.AdjustDateTime(0, true)
-        : baseDateTime.AdjustDateTimeForCurrentProvider();
+        : provider == StorageProvider.Oracle
+          ? baseDateTime.AdjustDateTime(6, true)
+          : baseDateTime.AdjustDateTimeForCurrentProvider();
+    }
   }
 }