Merge pull request #361 from DataObjects-NET/7.1-fix-tagtest-for-pg

TagTest improvements

Author: alex-kulakov

Orm/Xtensive.Orm.Tests.Framework/AutoBuildTest.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2003-2010 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2008-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2008.07.31
 
@@ -72,14 +72,15 @@ protected virtual void CheckRequirements()
     {
     }
 
-    protected void CreateSessionAndTransaction()
+    protected (Session, TransactionScope) CreateSessionAndTransaction()
     {
       try {
         disposables = new DisposableSet();
         var session = Domain.OpenSession();
-        disposables.Add(session);
         var transaction = session.OpenTransaction();
-        disposables.Add(transaction);
+        _ = disposables.Add(session);
+        _ = disposables.Add(transaction);
+        return (session, transaction);
       }
       catch {
         disposables.DisposeSafely();

Orm/Xtensive.Orm.Tests/Issues/Issue0435_BatchingFail.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2009-2020 Xtensive LLC.
+// Copyright (C) 2009-20223 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
@@ -38,7 +38,7 @@ protected override DomainConfiguration BuildConfiguration()
     public override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
-      CreateSessionAndTransaction();
+      _ = CreateSessionAndTransaction();
     }
 
     [Test]

Orm/Xtensive.Orm.Tests/Issues/IssueJira0187_TypeCastInContain.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
 // Created:    2011.09.06
 
@@ -53,7 +53,7 @@ protected override DomainConfiguration BuildConfiguration()
     public override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
-      CreateSessionAndTransaction();
+      _ = CreateSessionAndTransaction();
     }
 
     [Test]

Orm/Xtensive.Orm.Tests/Issues/IssueJira0221_UnableToTranslateAggregate.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2011-2021 Xtensive LLC.
+// Copyright (C) 2011-2023 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
@@ -54,7 +54,7 @@ public override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
 
-      CreateSessionAndTransaction();
+      _ = CreateSessionAndTransaction();
 
       _ = new ZamesInfo {Owner = new Zames(), Rank = 1};
       _ = new ZamesInfo {Owner = new Zames(), Rank = 3};

Orm/Xtensive.Orm.Tests/Issues/IssueJira0242_LegacyExecuteMethodsDoNotWork.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2012-2020 Xtensive LLC.
+// Copyright (C) 2012-2023 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
@@ -16,7 +16,7 @@ public class IssueJira0242_LegacyExecuteMethodsDoNotWork : AutoBuildTest
     public override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
-      CreateSessionAndTransaction();
+      _ = CreateSessionAndTransaction();
     }
 
     #region Compiled queries

Orm/Xtensive.Orm.Tests/Issues/IssueJira0746_LikeBehaviorDifferentOnClientSide.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2018-2020 Xtensive LLC.
+// Copyright (C) 2018-2023 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Denis Kudelin
@@ -87,7 +87,7 @@ public class IssueJira0746_LikeBehaviorDifferentOnClientSide : AutoBuildTest
     public override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
-      CreateSessionAndTransaction();
+      _ = CreateSessionAndTransaction();
     }
 
     protected override DomainConfiguration BuildConfiguration()

Orm/Xtensive.Orm.Tests/Linq/ConvariantQueriesTest.cs

@@ -1,6 +1,6 @@
-// Copyright (C) 2011 Xtensive LLC.
-// All rights reserved.
-// For conditions of distribution and use, see license.
+// Copyright (C) 2011-2023 Xtensive LLC.
+// This code is distributed under MIT license terms.
+// See the License.txt file in the project root for more information.
 // Created by: Denis Krjuchkov
 // Created:    2011.11.02
 
@@ -42,7 +42,7 @@ protected override DomainConfiguration BuildConfiguration()
     public override void TestFixtureSetUp()
     {
       base.TestFixtureSetUp();
-      CreateSessionAndTransaction();
+      _ = CreateSessionAndTransaction();
     }
 
     [Test]