Merge pull request #456 from DataObjects-NET/7.2-bunch-of-imps

Different code improvements

Author: alex-kulakov

ChangeLog/7.2.1-dev.txt

@@ -1,5 +1,9 @@
 [main] Added Query.SingleAsync()/SingleOrDefaultAsync and QueryEndpoint.SingleAsync()/SingleOrDefaultAsync methods
 [main] Addressed issue of not disposing IAsyncEnumerator which caused query being open
 [main] Addressed issue of overwriting exception on attempt to rollback the transaction of Domain upgrade if commit operation failed
+[main] LeftJoin extension marked as Obsolete to prepare movement to .NET 10, LeftJoinEx provided as substitution
+[main] IPriorityQueue interface became Obsolete
+[main] EnumerableUtils.One() marked as Obsolete
+[main] Performance and memory usage improvements
 [postgresql] Update Npgsql to 9.0.4
 [weaver] Updated Mono.Cecil package to v0.11.6, which resolves certain issues of unsynced pdb files

Extensions/Xtensive.Orm.Localization/Configuration/LocalizationConfiguration.cs

@@ -140,7 +140,7 @@ private static LocalizationConfiguration GetConfigurationFromSection(Configurati
     /// <returns>Loaded configuration or default configuration if loading failed for some reason.</returns>
     public static LocalizationConfiguration Load(IConfiguration configuration, string sectionName = null)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configuration, nameof(configuration));
+      ArgumentNullException.ThrowIfNull(configuration);
 
       if (configuration is IConfigurationRoot configurationRoot) {
         return new LocalizationConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
@@ -161,7 +161,7 @@ public static LocalizationConfiguration Load(IConfiguration configuration, strin
     /// <returns>Loaded configuration or default configuration if loading failed for some reason.</returns>
     public static LocalizationConfiguration Load(IConfigurationSection configurationSection)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configurationSection, nameof(configurationSection));
+      ArgumentNullException.ThrowIfNull(configurationSection);
 
       return new LocalizationConfigurationReader().Read(configurationSection);
     }
@@ -175,7 +175,7 @@ public static LocalizationConfiguration Load(IConfigurationSection configuration
     /// <returns>Loaded configuration or default configuration if loading failed for some reason.</returns>
     public static LocalizationConfiguration Load(IConfigurationRoot configurationRoot, string sectionName = null)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configurationRoot, nameof(configurationRoot));
+      ArgumentNullException.ThrowIfNull(configurationRoot);
 
       return new LocalizationConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
     }

Extensions/Xtensive.Orm.Localization/Internals/TypeLocalizationMap.cs

@@ -22,7 +22,7 @@ internal class TypeLocalizationMap
 
     public static void Initialize(Domain domain)
     {
-      ArgumentValidator.EnsureArgumentNotNull(domain, nameof(domain));
+      ArgumentNullException.ThrowIfNull(domain);
 
       var existing = domain.Extensions.Get<TypeLocalizationMap>();
       if (existing != null) {

Extensions/Xtensive.Orm.Localization/LocalizationContext.cs

@@ -77,8 +77,7 @@ public LocalizationContext(CultureInfo culture)
     /// <exception cref="ArgumentNullException"/>
     public LocalizationContext(CultureInfo culture, LocalizationPolicy policy)
     {
-      ArgumentValidator.EnsureArgumentNotNull(culture, "culture");
-      Culture = culture;
+      Culture = culture ?? throw new ArgumentNullException(nameof(culture));
       CultureName = culture.Name;
       Policy = policy;
     }

Extensions/Xtensive.Orm.Reprocessing/Configuration/ReprocessingConfiguration.cs

@@ -128,7 +128,7 @@ private static ReprocessingConfiguration GetConfigurationFromSection(Configurati
     /// <returns>Loaded configuration or configuration with default settings.</returns>
     public static ReprocessingConfiguration Load(IConfiguration configuration, string sectionName = null)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configuration, nameof(configuration));
+      ArgumentNullException.ThrowIfNull(configuration);
 
       if (configuration is IConfigurationRoot configurationRoot) {
         return new ReprocessingConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
@@ -149,7 +149,7 @@ public static ReprocessingConfiguration Load(IConfiguration configuration, strin
     /// <returns>Loaded configuration or configuration with default settings.</returns>
     public static ReprocessingConfiguration Load(IConfigurationRoot configurationRoot, string sectionName = null)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configurationRoot, nameof(configurationRoot));
+      ArgumentNullException.ThrowIfNull(configurationRoot);
 
       return new ReprocessingConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
     }
@@ -161,7 +161,7 @@ public static ReprocessingConfiguration Load(IConfigurationRoot configurationRoo
     /// <returns>Loaded configuration or configuration with default settings.</returns>
     public static ReprocessingConfiguration Load(IConfigurationSection configurationSection)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configurationSection, nameof(configurationSection));
+      ArgumentNullException.ThrowIfNull(configurationSection);
 
       return new ReprocessingConfigurationReader().Read(configurationSection);
     }

Extensions/Xtensive.Orm.Security/Configuration/SecurityConfiguration.cs

@@ -140,7 +140,7 @@ private static SecurityConfiguration GetConfigurationFromSection(ConfigurationSe
     /// <returns>Loaded configuration or configuration with default settings.</returns>
     public static SecurityConfiguration Load(IConfiguration configuration, string sectionName = null)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configuration, nameof(configuration));
+      ArgumentNullException.ThrowIfNull(configuration);
 
       if (configuration is IConfigurationRoot configurationRoot) {
         return Load(configurationRoot, sectionName);
@@ -161,7 +161,7 @@ public static SecurityConfiguration Load(IConfiguration configuration, string se
     /// <returns>Loaded configuration or configuration with default settings.</returns>
     public static SecurityConfiguration Load(IConfigurationRoot configurationRoot, string sectionName = null)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configurationRoot, nameof(configurationRoot));
+      ArgumentNullException.ThrowIfNull(configurationRoot);
 
       var configuration = new NamelessFormatSecurityConfigurationReader().Read(configurationRoot, sectionName ?? DefaultSectionName);
       if (configuration != null) {
@@ -179,7 +179,7 @@ public static SecurityConfiguration Load(IConfigurationRoot configurationRoot, s
     /// <returns>Loaded configuration or configuration with default settings.</returns>
     public static SecurityConfiguration Load(IConfigurationSection configurationSection)
     {
-      ArgumentValidator.EnsureArgumentNotNull(configurationSection, nameof(configurationSection));
+      ArgumentNullException.ThrowIfNull(configurationSection);
 
       var configuration = new NamelessFormatSecurityConfigurationReader().Read(configurationSection);
       if (configuration != null) {

Extensions/Xtensive.Orm.Security/ImpersonationContext.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using Xtensive.Core;
 
 namespace Xtensive.Orm.Security
@@ -63,7 +63,7 @@ protected virtual void Dispose(bool disposing)
     public ImpersonationContext(IPrincipal principal, ImpersonationContext outerContext)
       : base(principal.Session)
     {
-      ArgumentValidator.EnsureArgumentNotNull(principal, "principal");
+      ArgumentNullException.ThrowIfNull(principal);
 
       this.outerContext = outerContext;
       Principal = principal;

Extensions/Xtensive.Orm.Security/Services/GenericAuthenticationService.cs

@@ -22,7 +22,7 @@ public class GenericAuthenticationService : SessionBound, IAuthenticationService
     /// <inheritdoc/>
     public IPrincipal Authenticate(IIdentity identity, params object[] args)
     {
-      ArgumentValidator.EnsureArgumentNotNull(identity, "identity");
+      ArgumentNullException.ThrowIfNull(identity);
       ArgumentValidator.EnsureArgumentNotNullOrEmpty(identity.Name, "identity.Name");
 
       return Authenticate(identity.Name, args);

Extensions/Xtensive.Orm.Security/SessionExtensions.cs

@@ -45,7 +45,7 @@ public static SecurityConfiguration GetSecurityConfiguration(this Session sessio
     /// <returns><see cref="ImpersonationContext"/> instance.</returns>
     public static ImpersonationContext GetImpersonationContext(this Session session)
     {
-      ArgumentValidator.EnsureArgumentNotNull(session, "session");
+      ArgumentNullException.ThrowIfNull(session);
 
       return session.Extensions.Get<ImpersonationContext>();
     }
@@ -58,8 +58,8 @@ public static ImpersonationContext GetImpersonationContext(this Session session)
     /// <returns><see cref="ImpersonationContext"/> instance.</returns>
     public static ImpersonationContext Impersonate(this Session session, IPrincipal principal)
     {
-      ArgumentValidator.EnsureArgumentNotNull(session, "session");
-      ArgumentValidator.EnsureArgumentNotNull(principal, "principal");
+      ArgumentNullException.ThrowIfNull(session);
+      ArgumentNullException.ThrowIfNull(principal);
 
       var currentContext = session.GetImpersonationContext();
 
@@ -101,23 +101,23 @@ public static IPrincipal Authenticate(this Session session, string name, params
 
     private static void ClearImpersonationContext(this Session session)
     {
-      ArgumentValidator.EnsureArgumentNotNull(session, "session");
+      ArgumentNullException.ThrowIfNull(session);
 
       session.Extensions.Set<ImpersonationContext>(null);
     }
 
     private static void SetImpersonationContext(this Session session, ImpersonationContext context)
     {
-      ArgumentValidator.EnsureArgumentNotNull(session, "session");
-      ArgumentValidator.EnsureArgumentNotNull(context, "context");
+      ArgumentNullException.ThrowIfNull(session);
+      ArgumentNullException.ThrowIfNull(context);
 
       session.Extensions.Set(context);
     }
 
     internal static void UndoImpersonation(this Session session, ImpersonationContext innerContext, ImpersonationContext outerContext)
     {
-      ArgumentValidator.EnsureArgumentNotNull(session, "session");
-      ArgumentValidator.EnsureArgumentNotNull(innerContext, "innerContext");
+      ArgumentNullException.ThrowIfNull(session);
+      ArgumentNullException.ThrowIfNull(innerContext);
       // outerContext can be null
 
       var currentContext = session.GetImpersonationContext();

Extensions/Xtensive.Orm.Tracking/Internals/TrackingStackFrame.cs

@@ -4,6 +4,7 @@
 // Created by: Dmitri Maximov
 // Created:    2012.05.16
 
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using Xtensive.Core;
@@ -18,7 +19,7 @@ namespace Xtensive.Orm.Tracking
 
     public void Register(TrackingItem item)
     {
-      ArgumentValidator.EnsureArgumentNotNull(item, "item");
+      ArgumentNullException.ThrowIfNull(item);
 
       var key = item.Key;
       if (!items.TryGetValue(key, out var existing)) {