Cached TupleParameter

Author: alex-kulakov

Orm/Xtensive.Orm/Orm/Linq/Materialization/ExpressionMaterializer.cs

@@ -26,17 +26,14 @@ namespace Xtensive.Orm.Linq.Materialization
   [Serializable]
   internal class ExpressionMaterializer : PersistentExpressionVisitor
   {
-    private static readonly MethodInfo BuildPersistentTupleMethod;
-    private static readonly MethodInfo GetTupleSegmentMethod;
-    private static readonly MethodInfo GetParameterValueMethod;
-    private static readonly PropertyInfo ParameterContextProperty;
-    private static readonly MethodInfo GetTupleParameterValueMethod;
+    private static readonly MethodInfo BuildPersistentTupleMethod = typeof(ExpressionMaterializer).GetMethod(nameof(BuildPersistentTuple), BindingFlags.NonPublic | BindingFlags.Static);
+    private static readonly MethodInfo GetTupleSegmentMethod = typeof(ExpressionMaterializer).GetMethod(nameof(GetTupleSegment), BindingFlags.NonPublic | BindingFlags.Static);
+    private static readonly MethodInfo GetParameterValueMethod = WellKnownOrmTypes.ParameterContext.GetMethod(nameof(ParameterContext.GetValue));
+    private static readonly PropertyInfo ParameterContextProperty = WellKnownOrmTypes.ItemMaterializationContext.GetProperty(nameof(ItemMaterializationContext.ParameterContext));
+    private static readonly MethodInfo GetTupleParameterValueMethod = GetParameterValueMethod.MakeGenericMethod(WellKnownOrmTypes.Tuple);
 
-    private readonly TranslatorContext context;
-    private readonly ParameterExpression tupleParameter;
-    private readonly ParameterExpression itemMaterializationContextParameter;
-    private readonly Dictionary<IEntityExpression, int> entityRegistry = new Dictionary<IEntityExpression, int>();
-    private readonly HashSet<Parameter<Tuple>> tupleParameters;
+    private static readonly ParameterExpression MaterializationContextParameter = Expression.Parameter(WellKnownOrmTypes.ItemMaterializationContext, "mc");
+    private static readonly ConstantExpression TypeReferenceAccuracyConstantExpression = Expression.Constant(TypeReferenceAccuracy.BaseType);
 
     private static readonly Type[] SubQueryConstructorArgumentTypes = {
       WellKnownOrmTypes.ProjectionExpression,
@@ -46,23 +43,35 @@ internal class ExpressionMaterializer : PersistentExpressionVisitor
       WellKnownOrmTypes.ItemMaterializationContext
     };
 
+    private static readonly Type[] GroupingConstructorArgumentTypesTemplate = new[] {
+      WellKnownOrmTypes.ProjectionExpression,
+      WellKnownOrmTypes.TranslatedQuery,
+      WellKnownOrmTypes.ParameterOfTuple,
+      WellKnownOrmTypes.Tuple,
+      null,
+      WellKnownOrmTypes.ItemMaterializationContext
+    };
+
+    private readonly TranslatorContext context;
+    private readonly ParameterExpression tupleParameter;
+    private readonly ParameterExpression itemMaterializationContextParameter;
+    private readonly Dictionary<IEntityExpression, int> entityRegistry = new Dictionary<IEntityExpression, int>();
+    private readonly HashSet<Parameter<Tuple>> tupleParameters;
+
     #region Public static methods
 
     public static LambdaExpression MakeLambda(Expression expression, TranslatorContext context)
     {
-      var tupleParameter = Expression.Parameter(WellKnownOrmTypes.Tuple, "tuple");
-      var visitor = new ExpressionMaterializer(tupleParameter, context, null, EnumerableUtils<Parameter<Tuple>>.Empty);
+      var visitor = new ExpressionMaterializer(QueryHelper.TupleParameter, context, null, EnumerableUtils<Parameter<Tuple>>.Empty);
       var processedExpression = OwnerRemover.RemoveOwner(expression);
-      return FastExpression.Lambda(visitor.Visit(processedExpression), tupleParameter);
+      return FastExpression.Lambda(visitor.Visit(processedExpression), QueryHelper.TupleParameter);
     }
 
     public static MaterializationInfo MakeMaterialization(ItemProjectorExpression projector, TranslatorContext context, 
       IEnumerable<Parameter<Tuple>> tupleParameters)
     {
-      var tupleParameter = Expression.Parameter(WellKnownOrmTypes.Tuple, "tuple");
-      var materializationContextParameter = Expression.Parameter(WellKnownOrmTypes.ItemMaterializationContext, "mc");
-      var visitor = new ExpressionMaterializer(tupleParameter, context, materializationContextParameter, tupleParameters);
-      var lambda = FastExpression.Lambda(visitor.Visit(projector.Item), tupleParameter, materializationContextParameter);
+      var visitor = new ExpressionMaterializer(QueryHelper.TupleParameter, context, MaterializationContextParameter, tupleParameters);
+      var lambda = FastExpression.Lambda(visitor.Visit(projector.Item), QueryHelper.TupleParameter, MaterializationContextParameter);
       var count = visitor.entityRegistry.Count;
       return new MaterializationInfo(count, lambda);
     }
@@ -110,16 +119,14 @@ protected override Expression VisitGroupingExpression(GroupingExpression groupin
       // 2. Create constructor
       var keyType = groupingExpression.KeyExpression.Type;
       var keyMaterializer = Visit(groupingExpression.KeyExpression);
+      // Copying from template is 2x+ faster than instantiating an array with defined items
+      var ctorParameterTypes = new Type[GroupingConstructorArgumentTypesTemplate.Length];
+      Array.Copy(GroupingConstructorArgumentTypesTemplate, ctorParameterTypes, GroupingConstructorArgumentTypesTemplate.Length);
+      ctorParameterTypes[4] = keyType;
+
       var groupingCtor = WellKnownOrmTypes.GroupingOfTKeyTElement
         .MakeGenericType(keyType, elementType)
-        .GetConstructor(new[] {
-          WellKnownOrmTypes.ProjectionExpression,
-          WellKnownOrmTypes.TranslatedQuery,
-          WellKnownOrmTypes.ParameterOfTuple,
-          WellKnownOrmTypes.Tuple,
-          keyType,
-          WellKnownOrmTypes.ItemMaterializationContext
-        });
+        .GetConstructor(ctorParameterTypes);
 
       // 3. Create result expression.
       var resultExpression = Expression.New(
@@ -321,7 +328,7 @@ protected override Expression VisitKeyExpression(KeyExpression expression)
           Expression.Field(itemMaterializationContextParameter, ItemMaterializationContext.SessionFieldInfo),
           WellKnownMembers.SessionNodeId),
         Expression.Constant(expression.EntityType),
-        Expression.Constant(TypeReferenceAccuracy.BaseType),
+        TypeReferenceAccuracyConstantExpression,
         tupleExpression);
     }
 

Orm/Xtensive.Orm/Orm/Linq/QueryHelper.cs

@@ -33,17 +33,19 @@ public OwnerWrapper(TOwner owner)
       }
     }
 
+    public static readonly ParameterExpression TupleParameter = Expression.Parameter(WellKnownOrmTypes.Tuple, "tuple");
+
+    private static readonly PropertyInfo TupleValueProperty = WellKnownOrmTypes.ParameterOfTuple
+      .GetProperty(nameof(Parameter<Tuple>.Value), WellKnownOrmTypes.Tuple);
+
     public static Expression<Func<Tuple, bool>> BuildFilterLambda(int startIndex, IReadOnlyList<Type> keyColumnTypes, Parameter<Tuple> keyParameter)
     {
       Expression filterExpression = null;
-      var tupleParameter = Expression.Parameter(WellKnownOrmTypes.Tuple, "tuple");
-      var valueProperty = WellKnownOrmTypes.ParameterOfTuple
-        .GetProperty(nameof(Parameter<Tuple>.Value), WellKnownOrmTypes.Tuple);
-      var keyValue = Expression.Property(Expression.Constant(keyParameter), valueProperty);
-      for (var i = 0; i < keyColumnTypes.Count; i++) {
+      var keyValue = Expression.Property(Expression.Constant(keyParameter), TupleValueProperty);
+      for (int i = 0, count = keyColumnTypes.Count; i < count; i++) {
         var getValueMethod = WellKnownMembers.Tuple.GenericAccessor.MakeGenericMethod(keyColumnTypes[i]);
         var tupleParameterFieldAccess = Expression.Call(
-          tupleParameter,
+          TupleParameter,
           getValueMethod,
           Expression.Constant(startIndex + i));
         var keyParameterFieldAccess = Expression.Call(
@@ -56,7 +58,7 @@ public static Expression<Func<Tuple, bool>> BuildFilterLambda(int startIndex, IR
           filterExpression = Expression.And(filterExpression,
             Expression.Equal(tupleParameterFieldAccess, keyParameterFieldAccess));
       }
-      return FastExpression.Lambda<Func<Tuple, bool>>(filterExpression, tupleParameter);
+      return FastExpression.Lambda<Func<Tuple, bool>>(filterExpression, TupleParameter);
     }
 
     private static Expression CreateEntityQuery(Type elementType)

Orm/Xtensive.Orm/Orm/Linq/Translator.Queryable.cs

@@ -959,7 +959,7 @@ private ProjectionExpression VisitGroupBy(Type returnType, Expression source, La
           Type = keyDataSource.Header.Columns[groupIndex].Type.ToNullable()
         });
       var applyParameter = context.GetApplyParameter(groupingProjection);
-      var tupleParameter = Expression.Parameter(WellKnownOrmTypes.Tuple, "tuple");
+      var tupleParameter = QueryHelper.TupleParameter;
 
       var filterBody = (nullableKeyColumns.Count == 0)
         ? comparisonInfos.Aggregate(