Use fixtures to control SHOW_SPLASH in tests

Replace the autouse fixture with explicit fixtures to toggle dlclivegui.gui.theme.SHOW_SPLASH per-test. Adds set_use_splash_true and set_use_splash_false fixtures, updates tests to accept them, and removes the manual SHOW_SPLASH override in test_main_without_splash. Also fixes a comment typo (thems.py -> theme.py) to make splash behavior explicit and avoid cross-test side effects.

Author: C-Achard

tests/gui/test_app_entrypoint.py

@@ -24,14 +24,20 @@ def _import_fresh():
     return importlib.import_module(MODULE_UNDER_TEST)
 
 
-@pytest.fixture(autouse=True)
+@pytest.fixture
 def set_use_splash_true(monkeypatch):
-    #  Ensure thems.py SHOW_SPLASH is True for tests that rely on it, without affecting other tests
+    #  Ensure theme.py SHOW_SPLASH is True for tests that rely on it, without affecting other tests
     monkeypatch.setattr("dlclivegui.gui.theme.SHOW_SPLASH", True)
 
 
+@pytest.fixture
+def set_use_splash_false(monkeypatch):
+    #  Ensure theme.py SHOW_SPLASH is False for tests that rely on it, without affecting other tests
+    monkeypatch.setattr("dlclivegui.gui.theme.SHOW_SPLASH", False)
+
+
 @pytest.mark.gui
-def test_main_with_splash(monkeypatch):
+def test_main_with_splash(monkeypatch, set_use_splash_true):
     appmod = _import_fresh()
 
     # --- Patch Qt app & icon in the entry module's namespace ---
@@ -101,7 +107,7 @@ def immediate_single_shot(ms, fn):
 
 
 @pytest.mark.gui
-def test_main_without_splash(monkeypatch):
+def test_main_without_splash(monkeypatch, set_use_splash_false):
     appmod = _import_fresh()
 
     # Patch Qt app creation & window icon
@@ -111,9 +117,6 @@ def test_main_without_splash(monkeypatch):
     monkeypatch.setattr(appmod, "QApplication", QApplication_cls)
     monkeypatch.setattr(appmod, "QIcon", MagicMock(name="QIcon"))
 
-    # Force the no-splash branch
-    appmod.SHOW_SPLASH = False
-
     # show_splash should not be called
     show_splash_mock = MagicMock(name="show_splash")
     monkeypatch.setattr(appmod, "show_splash", show_splash_mock)