Skip to content

Commit f7931df

Browse files
committed
WIP Adjust two-field row layout and scroll margins
Update CameraConfigDialog layout: extend _make_two_field_row signature with left_stretch and right_stretch (default 1) to allow controlling widget stretch, increase label minimum width to 30 for better alignment, and reduce the inter-field spacing from 12 to 8. Also add a 10px bottom contents margin to the scroll area to provide extra padding. Changes are backwards-compatible due to default parameter values.
1 parent 19117e7 commit f7931df

1 file changed

Lines changed: 13 additions & 7 deletions

File tree

dlclivegui/gui/camera_config_dialog.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,13 @@ def _merge_backend_settings_back(self, opened_settings: CameraSettings) -> None:
308308
# UI setup
309309
# -------------------------------
310310
def _make_two_field_row(
311-
self, left_label: str, left_widget: QWidget, right_label: str, right_widget: QWidget
311+
self,
312+
left_label: str,
313+
left_widget: QWidget,
314+
right_label: str,
315+
right_widget: QWidget,
316+
left_stretch: int = 1,
317+
right_stretch: int = 1,
312318
) -> QWidget:
313319
"""Create a compact two-field row widget: (label+widget) (label+widget)."""
314320
row = QWidget()
@@ -317,16 +323,16 @@ def _make_two_field_row(
317323
layout.setSpacing(8)
318324

319325
l1 = QLabel(left_label)
320-
l1.setMinimumWidth(10)
326+
l1.setMinimumWidth(30)
321327
layout.addWidget(l1, 0)
322-
layout.addWidget(left_widget, 1)
328+
layout.addWidget(left_widget, left_stretch)
323329

324-
layout.addSpacing(12)
330+
layout.addSpacing(8)
325331

326332
l2 = QLabel(right_label)
327-
l2.setMinimumWidth(10)
333+
l2.setMinimumWidth(30)
328334
layout.addWidget(l2, 0)
329-
layout.addWidget(right_widget, 1)
335+
layout.addWidget(right_widget, right_stretch)
330336

331337
return row
332338

@@ -626,7 +632,7 @@ def _setup_ui(self) -> None:
626632
scroll_contents.setMinimumWidth(scroll.viewport().width())
627633
scroll.viewport().installEventFilter(self)
628634
scroll_layout = QVBoxLayout(scroll_contents)
629-
scroll_layout.setContentsMargins(0, 0, 0, 0)
635+
scroll_layout.setContentsMargins(0, 0, 0, 10)
630636
scroll_layout.setSpacing(10)
631637

632638
# Give groups a sane size policy; scroll handles overflow

0 commit comments

Comments
 (0)