Properly dispose Process instances (fix #3366)

Author: marticliment

src/UniGetUI.Core.Data/CoreData.cs

@@ -377,7 +377,7 @@ private static int GetCodePage()
         {
             try
             {
-                Process p = new Process
+                using Process p = new Process
                 {
                     StartInfo = new ProcessStartInfo
                     {

src/UniGetUI.Core.Tools/Tools.cs

@@ -264,7 +264,7 @@ Inner exception ({i}):
         /// <param name="RunAsAdmin">Whether the batch file should be launched elevated or not</param>
         public static async void LaunchBatchFile(string path, string WindowTitle = "", bool RunAsAdmin = false)
         {
-            Process p = new();
+            using Process p = new();
             p.StartInfo.FileName = "cmd.exe";
             p.StartInfo.Arguments = "/C start \"" + WindowTitle + "\" \"" + path + "\"";
             p.StartInfo.UseShellExecute = true;
@@ -501,7 +501,7 @@ public static string EnsureSafeQueryString(string query)
         public static async Task CacheUACForCurrentProcess()
         {
             Logger.Info("Caching admin rights for process id " + Environment.ProcessId);
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {
@@ -525,7 +525,7 @@ public static async Task CacheUACForCurrentProcess()
         public static async Task ResetUACForCurrentProcess()
         {
             Logger.Info("Resetting administrator rights cache for process id " + Environment.ProcessId);
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {

src/UniGetUI.PackageEngine.Managers.Cargo/Cargo.cs

@@ -73,7 +73,7 @@ public Cargo()
 
     protected override IReadOnlyList<Package> FindPackages_UnSafe(string query)
     {
-        Process p = GetProcess(Status.ExecutablePath, "search -q --color=never " + query);
+        using Process p = GetProcess(Status.ExecutablePath, "search -q --color=never " + query);
         IProcessTaskLogger logger = TaskLogger.CreateNew(LoggableTaskType.FindPackages, p);
         p.Start();
 
@@ -142,7 +142,7 @@ protected override ManagerStatus LoadManager()
             return new(){ ExecutablePath = executablePath, Found = false, Version = ""};
         }
 
-        Process p = GetProcess(executablePath, "--version");
+        using Process p = GetProcess(executablePath, "--version");
         p.Start();
         string version = p.StandardOutput.ReadToEnd().Trim();
         string error = p.StandardError.ReadToEnd();
@@ -174,7 +174,7 @@ private IReadOnlyList<Package> GetPackages(LoggableTaskType taskType)
     private List<Match> GetInstalledCommandOutput()
     {
         List<Match> output = [];
-        Process p = GetProcess(Status.ExecutablePath, "install-update --list");
+        using Process p = GetProcess(Status.ExecutablePath, "install-update --list");
         IProcessTaskLogger logger = TaskLogger.CreateNew(LoggableTaskType.OtherTask, p);
         logger.AddToStdOut("Other task: Call the install-update command");
         p.Start();

src/UniGetUI.PackageEngine.Managers.Chocolatey/Chocolatey.cs

@@ -65,7 +65,7 @@ public Chocolatey()
 
         protected override IReadOnlyList<Package> GetAvailableUpdates_UnSafe()
         {
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {
@@ -119,7 +119,7 @@ protected override IReadOnlyList<Package> GetAvailableUpdates_UnSafe()
 
         protected override IReadOnlyList<Package> _getInstalledPackages_UnSafe()
         {
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {

src/UniGetUI.PackageEngine.Managers.Chocolatey/Helpers/ChocolateyDetailsHelper.cs

@@ -13,7 +13,7 @@ public ChocolateyDetailsHelper(BaseNuGet manager) : base(manager)
 
         protected override IReadOnlyList<string> GetInstallableVersions_UnSafe(IPackage package)
         {
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {

src/UniGetUI.PackageEngine.Managers.Chocolatey/Helpers/ChocolateySourceHelper.cs

@@ -35,7 +35,7 @@ protected override IReadOnlyList<IManagerSource> GetSources_UnSafe()
         {
             List<ManagerSource> sources = [];
 
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new()
                 {

src/UniGetUI.PackageEngine.Managers.Dotnet/DotNet.cs

@@ -62,7 +62,7 @@ protected override IReadOnlyList<Package> _getInstalledPackages_UnSafe()
             List<Package> Packages = [];
             foreach (var options in new OverridenInstallationOptions[] { new(PackageScope.Local), new(PackageScope.Global) })
             {
-                Process p = new()
+                using Process p = new()
                 {
                     StartInfo = new ProcessStartInfo
                     {

src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgDetailsHelper.cs

@@ -93,7 +93,7 @@ protected override IReadOnlyList<Uri> GetScreenshots_UnSafe(IPackage package)
 
         protected override IReadOnlyList<string> GetInstallableVersions_UnSafe(IPackage package)
         {
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {

src/UniGetUI.PackageEngine.Managers.Npm/Npm.cs

@@ -47,7 +47,7 @@ public Npm()
 
         protected override IReadOnlyList<Package> FindPackages_UnSafe(string query)
         {
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {
@@ -99,7 +99,7 @@ protected override IReadOnlyList<Package> GetAvailableUpdates_UnSafe()
             List<Package> Packages = [];
             foreach (var options in new OverridenInstallationOptions[] { new(PackageScope.Local), new(PackageScope.Global) })
             {
-                Process p = new()
+                using Process p = new()
                 {
                     StartInfo = new ProcessStartInfo
                     {
@@ -145,7 +145,7 @@ protected override IReadOnlyList<Package> GetInstalledPackages_UnSafe()
             List<Package> Packages = [];
             foreach (var options in new OverridenInstallationOptions[] { new(PackageScope.Local), new(PackageScope.Global) })
             {
-                Process p = new()
+                using Process p = new()
                 {
                     StartInfo = new ProcessStartInfo
                     {

src/UniGetUI.PackageEngine.Managers.Pip/Helpers/PipPkgDetailsHelper.cs

@@ -96,7 +96,7 @@ protected override IReadOnlyList<Uri> GetScreenshots_UnSafe(IPackage package)
 
         protected override IReadOnlyList<string> GetInstallableVersions_UnSafe(IPackage package)
         {
-            Process p = new()
+            using Process p = new()
             {
                 StartInfo = new ProcessStartInfo
                 {