Properly support disabling triggers

Author: koenbeuk

src/EntityFrameworkCore.Triggered/TriggerSession.cs

@@ -48,6 +48,11 @@ public async Task RaiseTriggers(Type openTriggerType, Exception? exception, ITri
                 throw new ArgumentNullException(nameof(triggerContextDiscoveryStrategy));
             }
 
+            if (_configuration.Disabled)
+            {
+                return;
+            }
+
             cancellationToken.ThrowIfCancellationRequested();
 
             var triggerContextDescriptorBatches = triggerContextDiscoveryStrategy.Discover(_configuration, _tracker, _logger);

test/EntityFrameworkCore.Triggered.Tests/TriggerSessionTests.cs

@@ -412,5 +412,30 @@ public void RaiseAfterSaveTriggers_ModifiedEntity_HasAccessToUnmodifiedEntity()
             Assert.Equal("test1", _capturedTriggerContext.UnmodifiedEntity.Name);
             Assert.Equal("test2", _capturedTriggerContext.Entity.Name);
         }
+
+        [Fact]
+        public async Task RaiseTriggers_DisabledConfiguration_Noop()
+        {
+            // arrange
+            using var context = new TestDbContext();
+
+            var triggerService = context.GetService<ITriggerService>();
+            triggerService.Configuration = triggerService.Configuration with {
+                Disabled = true
+            };
+
+            var subject = triggerService.CreateSession(context);
+
+            context.TestModels.Add(new TestModel {
+                Id = 1,
+                Name = "test1"
+            });
+
+            // act
+            await subject.RaiseBeforeSaveTriggers();
+
+            // assert
+            Assert.Equal(0, context.TriggerStub.BeforeSaveInvocations.Count);
+        }
     }
 }

test/EntityFrameworkCore.Triggered.Tests/TriggeredDbContextTests.cs

@@ -539,5 +539,29 @@ public async Task SaveChangesAsync_DisposesTriggerSession()
 
             Assert.Equal(1, triggerServiceStub.LastSession.DisposeCalls);
         }
+
+        [Fact]
+        public async Task SaveChangesAsync_DisabledConfiguration_Noop()
+        {
+            // arrange
+            var serviceProvider = new ServiceCollection().BuildServiceProvider();
+
+            var subject = new TestDbContext(serviceProvider, false);
+            var triggerService = subject.GetService<ITriggerService>();
+            triggerService.Configuration = triggerService.Configuration with {
+                Disabled = true
+            };
+
+            subject.TestModels.Add(new TestModel {
+                Id = Guid.NewGuid(),
+                Name = "test1"
+            });
+
+            // act
+            await subject.SaveChangesAsync();
+
+            // assert
+            Assert.Empty(subject.TriggerStub.BeforeSaveInvocations);
+        }
     }
 }