All components methods as protected

Because it helps the IDE help us find unused code that can be dropped.
And it is rather rare to need them to be public.

Author: PowerKiKi

client/app/admin/facilitator-documents/facilitator-document/facilitator-document.component.ts

@@ -59,7 +59,7 @@ export class FacilitatorDocumentComponent extends NaturalAbstractDetail<
         super('facilitatorDocument', inject(FacilitatorDocumentsService));
     }
 
-    public createFileAndLink(file: File): Observable<CreateFile['createFile']> {
+    protected createFileAndLink(file: File): Observable<CreateFile['createFile']> {
         return this.fileService.create({file}).pipe(
             switchMap(newFile => {
                 const id = this.data.model.id;

client/app/admin/order/order/order.component.ts

@@ -68,7 +68,7 @@ export class OrderComponent {
         });
     }
 
-    public updateStatus(status: string | string[] | null): void {
+    protected updateStatus(status: string | string[] | null): void {
         if (typeof status !== 'string') {
             return;
         }

client/app/admin/products/product/product.component.ts

@@ -88,7 +88,7 @@ export class ProductComponent extends NaturalAbstractDetail<ProductService, Natu
         super('product', inject(ProductService));
     }
 
-    public createFileAndLink(file: File): Observable<CreateFile['createFile']> {
+    protected createFileAndLink(file: File): Observable<CreateFile['createFile']> {
         return this.fileService.create({file}).pipe(
             switchMap(newFile => {
                 const id = this.data.model.id;
@@ -104,7 +104,9 @@ export class ProductComponent extends NaturalAbstractDetail<ProductService, Natu
         );
     }
 
-    public createImageAndLink(key: 'illustration' | 'image'): (file: File) => Observable<CreateImage['createImage']> {
+    protected createImageAndLink(
+        key: 'illustration' | 'image',
+    ): (file: File) => Observable<CreateImage['createImage']> {
         return file =>
             this.imageService.create({file}).pipe(
                 switchMap(image => {

client/app/admin/sessions/session/session.component.ts

@@ -80,7 +80,7 @@ export class SessionComponent extends NaturalAbstractDetail<SessionService, Natu
         this.form.setControl('dates', this.datesForm);
     }
 
-    public addDate(): void {
+    protected addDate(): void {
         this.datesForm.push(new FormControl(''));
     }
 }

client/app/admin/users/import/import.component.ts

@@ -61,7 +61,7 @@ export class ImportComponent implements OnInit {
         this.routeData = this.route.snapshot.data as NaturalSeoResolveData;
     }
 
-    public uploadFile(selection: FileSelection): void {
+    protected uploadFile(selection: FileSelection): void {
         this.errors = [];
         this.result = null;
         this.users = [];
@@ -118,7 +118,7 @@ export class ImportComponent implements OnInit {
             });
     }
 
-    public deleteAll(): void {
+    protected deleteAll(): void {
         this.alertService
             .confirm(
                 'Suppression',

client/app/admin/users/user/user.component.ts

@@ -91,7 +91,7 @@ export class UserComponent extends NaturalAbstractDetail<UserService, NaturalSeo
         });
     }
 
-    public roleDisabled(): (item: IEnum) => boolean {
+    protected roleDisabled(): (item: IEnum) => boolean {
         return item => {
             return !this.userRolesAvailable.includes(item.value as UserRole);
         };

client/app/front-office/components/comment-list/comment-list.component.ts

@@ -72,7 +72,7 @@ export class CommentListComponent extends NaturalAbstractList<CommentService> im
         }
     }
 
-    public addComment(): void {
+    protected addComment(): void {
         this.publishing = true;
         const comment = {
             description: this.newCommentValue,

client/app/front-office/components/home-block/home-block.component.ts

@@ -79,7 +79,7 @@ export class HomeBlockComponent implements OnInit {
         });
     }
 
-    public update(): void {
+    protected update(): void {
         const key = this.key();
         this.configService.set(key + '-title', this.form.getRawValue().title);
         this.configService.set(key + '-description', this.form.getRawValue().description);
@@ -88,7 +88,7 @@ export class HomeBlockComponent implements OnInit {
         this.lastValue = this.form.getRawValue();
     }
 
-    public reset(): void {
+    protected reset(): void {
         if (this.lastValue) {
             this.form.setValue(this.lastValue);
         }

client/app/front-office/components/login/login.component.ts

@@ -61,7 +61,7 @@ export class LoginComponent implements OnInit {
         }
     }
 
-    public maybeConfirm(): void {
+    protected maybeConfirm(): void {
         ifValid(this.form).subscribe(() => this.login());
     }
 

client/app/front-office/components/menu/menu.component.ts

@@ -35,7 +35,7 @@ export class MenuComponent {
     /**
      * Toggle open parent nodes, and allow navigation only on children
      */
-    public clickAction(item: MenuItem, event: Event): void {
+    protected clickAction(item: MenuItem, event: Event): void {
         this.data.items.forEach(i => (i.open = false));
 
         if (item.children?.length) {