Skip to content

Commit 78f9f62

Browse files
authored
Fix the release github action (#790)
* Fix var in release-notes target in makefile * Remove body_path, it apparently is no longer supported
1 parent d2f3d5f commit 78f9f62

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ jobs:
117117
release_name: Release ${{ env.PACKAGE_VERSION }}
118118
draft: false
119119
prerelease: false
120-
body_path: ./release_notes.md
121120
- name: Dependency Graph
122121
run: make dependency-graph-ci
123122
- name: Upload Dependency Graph as Artifact

Makefile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -224,16 +224,16 @@ release-zip-ci:
224224

225225
release-notes:
226226
@echo 📝 GENERATE RELEASE NOTES
227-
export MILESTONE_NUM=$(cat $GITHUB_EVENT_PATH | jq '.milestone.number')
228-
export MILESTONE_URL=$(cat $GITHUB_EVENT_PATH | jq '.milestone.url')
229-
export MILESTONE_TITLE=$(cat $GITHUB_EVENT_PATH | jq '.milestone.title')
230-
export MILESTONE_DESCRIPTION=$(cat $GITHUB_EVENT_PATH | jq '.milestone.description')
227+
export MILESTONE_NUM=$(cat ${GITHUB_EVENT_PATH} | jq '.milestone.number')
228+
export MILESTONE_URL=$(cat ${GITHUB_EVENT_PATH} | jq '.milestone.url')
229+
export MILESTONE_TITLE=$(cat ${GITHUB_EVENT_PATH} | jq '.milestone.title')
230+
export MILESTONE_DESCRIPTION=$(cat ${GITHUB_EVENT_PATH} | jq '.milestone.description')
231231
touch release_notes.md
232-
echo "# $MILESTONE_TITLE" >> release_notes.md
233-
echo "$MILESTONE_DESCRIPTION" >> release_notes.md
232+
echo "# ${MILESTONE_TITLE}" >> release_notes.md
233+
echo "${MILESTONE_DESCRIPTION}" >> release_notes.md
234234
echo -en "\n" >> release_notes.md
235235
echo "## Issues" >> release_notes.md
236-
curl "${GITHUB_API_URL}/${GITHUB_REPOSITORY}/issues?milestone=${MILESTONE_NUM}&state=all" | jq '.[].title' | while read i; do echo "[$i]($MILESTONE_URL)" >> release_notes.md; done
236+
curl "${GITHUB_API_URL}/${GITHUB_REPOSITORY}/issues?milestone=${MILESTONE_NUM}&state=all" | jq '.[].title' | while read i; do echo "[$i](${MILESTONE_URL})" >> release_notes.md; done
237237

238238
egui:
239239
ifeq "${EG_DB_PASSWORD}" ""

0 commit comments

Comments
 (0)