Skip to content

Commit 1a964b4

Browse files
committed
BrowserWindow tests: use about:blank as url
1 parent dfcb234 commit 1a964b4

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/ElectronNET.IntegrationTests/ElectronFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public async Task InitializeAsync()
2222
Show = false,
2323
Width = 800,
2424
Height = 600,
25-
});
25+
}, "about:blank");
2626

2727
// Clear potential cache side-effects
2828
await this.MainWindow.WebContents.Session.ClearCacheAsync();

src/ElectronNET.IntegrationTests/Tests/BrowserWindowTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public async Task MenuBar_auto_hide_and_visibility()
105105
[Fact(Timeout = 20000)]
106106
public async Task ReadyToShow_event_fires_after_content_ready()
107107
{
108-
var window = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false });
108+
var window = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false }, "about:blank");
109109
var tcs = new TaskCompletionSource();
110110
window.OnReadyToShow += () => tcs.TrySetResult();
111111

@@ -125,7 +125,7 @@ public async Task ReadyToShow_event_fires_after_content_ready()
125125
[Fact(Timeout = 20000)]
126126
public async Task PageTitleUpdated_event_fires_on_title_change()
127127
{
128-
var window = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = true });
128+
var window = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = true }, "about:blank");
129129
var tcs = new TaskCompletionSource<string>();
130130
window.OnPageTitleUpdated += title => tcs.TrySetResult(title);
131131

@@ -145,7 +145,7 @@ public async Task PageTitleUpdated_event_fires_on_title_change()
145145
[Fact(Timeout = 20000)]
146146
public async Task Resize_event_fires_on_size_change()
147147
{
148-
var window = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false });
148+
var window = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false }, "about:blank");
149149
var resized = false;
150150
window.OnResize += () => resized = true;
151151
window.SetSize(500, 400);
@@ -178,7 +178,7 @@ public async Task Menu_bar_visibility_and_auto_hide()
178178
[Fact(Timeout = 20000)]
179179
public async Task Parent_child_relationship_roundtrip()
180180
{
181-
var child = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false, Width = 300, Height = 200 });
181+
var child = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false, Width = 300, Height = 200 }, "about:blank");
182182
this.fx.MainWindow.SetParentWindow(null); // ensure top-level
183183
child.SetParentWindow(this.fx.MainWindow);
184184
var parent = await child.GetParentWindowAsync();

src/ElectronNET.IntegrationTests/Tests/ProcessTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class ProcessTests
99
public async Task Process_info_is_accessible()
1010
{
1111
// Use renderer to fetch process info and round-trip
12-
var execPath = await Electron.WindowManager.CreateWindowAsync(new API.Entities.BrowserWindowOptions { Show = false });
12+
var execPath = await Electron.WindowManager.CreateWindowAsync(new API.Entities.BrowserWindowOptions { Show = false }, "about:blank");
1313
var result = await execPath.WebContents.ExecuteJavaScriptAsync<string>("process.execPath && process.platform ? 'ok' : 'fail'");
1414
result.Should().Be("ok");
1515
}

0 commit comments

Comments
 (0)