Fix #277: Cache each ticket only once

Author: NMertsch

pyproject.toml

@@ -72,3 +72,6 @@ ignore = [
 
 [tool.ruff.lint.pydocstyle]
 convention = "pep257"
+
+[tool.mypy]
+plugins = ['pydantic.mypy']

src/europython_discord/registration/pretix_connector.py

@@ -20,7 +20,7 @@
 
 class PretixCache(BaseModel):
     item_names_by_id: dict[int, str]
-    tickets_by_key: dict[str, list[Ticket]]
+    tickets_by_key: dict[str, set[Ticket]]
 
 
 class PretixConnector:
@@ -36,7 +36,7 @@ def __init__(self, *, url: str, token: str, cache_file: Path | None = None) -> N
         self._cache_file = cache_file
 
         self.item_names_by_id: dict[int, str] = {}
-        self.tickets_by_key: dict[str, list[Ticket]] = defaultdict(list)
+        self.tickets_by_key: dict[str, set[Ticket]] = defaultdict(set)
 
         self._load_cache()
 
@@ -111,7 +111,7 @@ async def _fetch_pretix_orders(self, since: datetime | None = None) -> None:
                     variation=variation_name,
                 )
                 if order.is_paid:
-                    self.tickets_by_key[ticket.key].append(ticket)
+                    self.tickets_by_key[ticket.key].add(ticket)
                 elif ticket.key in self.tickets_by_key:  # remove cancelled tickets
                     self.tickets_by_key.pop(ticket.key)
 
@@ -174,6 +174,6 @@ def get_tickets(self, *, order: str, name: str) -> list[Ticket]:
             key = generate_ticket_key(order=order, name=possible_name)
 
             if key in self.tickets_by_key:
-                return self.tickets_by_key[key]
+                return list(self.tickets_by_key[key])
 
         return []

tests/registration/test_pretix_connector.py

@@ -106,15 +106,15 @@ async def test_pretix_orders(pretix_mock):
     await pretix_connector.fetch_pretix_data()
 
     assert pretix_connector.tickets_by_key == {
-        "BR7UH-evanovakova": [
+        "BR7UH-evanovakova": {
             Ticket(order="BR7UH", name="Eva Nováková", type="Business", variation="Conference")
-        ],
-        "BR7UH-jannovak": [
+        },
+        "BR7UH-jannovak": {
             Ticket(order="BR7UH", name="Jan Novák", type="Business", variation="Tutorials")
-        ],
-        "RCZN9-maijameikalainen": [
+        },
+        "RCZN9-maijameikalainen": {
             Ticket(order="RCZN9", name="Maija Meikäläinen", type="Personal", variation=None)
-        ],
+        },
     }