Skip to content

Commit fd41177

Browse files
committed
refactor: check cmake TODO and useless options
1 parent 958d7b7 commit fd41177

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ set(CMAKE_PROJECT_TOP_LEVEL_INCLUDES ${CMAKE_SOURCE_DIR}/conan_provider.cmake CA
66
project(Explosion)
77

88
option(BUILD_EDITOR "Build Explosion editor" ON)
9-
option(CI "Build in CI" OFF)
109

1110
set(SUB_PROJECT_NAME "Engine" CACHE STRING "" FORCE)
1211
set(ENGINE_SUB_PROJECT_NAME "Engine" CACHE STRING "" FORCE)

Editor/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ elseif (${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
9393
)
9494
endif ()
9595

96+
# TODO check is this need ?
9697
if (${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
9798
foreach (rhi_dep_target ${RHI_DEP_TARGETS})
9899
list(APPEND rhi_dep_target_copy_commands COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_FILE:${rhi_dep_target}> $<TARGET_FILE_DIR:Editor>/../Frameworks/$<TARGET_FILE_NAME:${rhi_dep_target}>)
99-
# TODO also copy runtime dep of runtime dep
100100
endforeach ()
101101

102102
add_custom_command(

0 commit comments

Comments
 (0)