rename "No link" to "No telemetry"

Author: jurgelenas

README.md

@@ -102,7 +102,7 @@ The simulator supports multiple test scenarios, configurable via the `config.sce
 | Scenario | Description |
 |----------|-------------|
 | `normal` | TX + RX connected. Happy path with full telemetry and all parameters. |
-| `disconnected` | TX present but no RX. Shows "No link" state. |
+| `no_telemetry` | TX present but no RX telemetry. Shows "No telemetry" state. |
 | `reconnect` | Starts disconnected, transitions to connected after ~5 seconds. |
 | `model_mismatch` | TX + RX connected with Model ID mismatch flag. Triggers warning dialog. |
 | `armed` | TX + RX connected with "is Armed" warning flag. |

src/SCRIPTS/ELRS/crsf.lua

@@ -70,8 +70,8 @@ CRSF._handlers = {}
 -- Device info cache (populated by built-in DEVICE_INFO handler)
 CRSF.deviceInfo = {}
 
--- RX connection state (populated by built-in ELRS_STATUS handler)
-CRSF.rxConnected = false
+-- Telemetry state (populated by built-in ELRS_STATUS handler)
+CRSF.hasTelemetry = false
 CRSF.modelMismatch = false
 CRSF.elrsFlags = 0
 CRSF.elrsFlagsInfo = ""
@@ -245,7 +245,7 @@ function CRSF:requestDeviceInfo()
 end
 
 --- Request ELRS status from the TX module (PARAMETER_WRITE with fieldId=0).
--- Updates rxConnected via the ELRS_STATUS handler on the next poll().
+-- Updates hasTelemetry via the ELRS_STATUS handler on the next poll().
 -- Rate-limited to at most once per second.
 function CRSF:requestElrsStatus()
   local now = getTime()
@@ -395,10 +395,10 @@ local function onDeviceInfo(data)
   end
 end
 
--- ELRS_STATUS handler: updates rxConnected, modelMismatch, elrsFlagsInfo
+-- ELRS_STATUS handler: updates hasTelemetry, modelMismatch, elrsFlagsInfo
 local function onElrsStatus(data)
   CRSF.elrsFlags = data[6] or 0
-  CRSF.rxConnected = bit32.btest(CRSF.elrsFlags, 1)
+  CRSF.hasTelemetry = bit32.btest(CRSF.elrsFlags, 1)
   CRSF.modelMismatch = bit32.btest(CRSF.elrsFlags, 4)
 
   -- Parse null-terminated warning info string starting at data[7]

src/SCRIPTS/TOOLS/ExpressLRS/protocol.lua

@@ -100,8 +100,8 @@ local Protocol = {
   expectChunksRemain = -1,
   backgroundLoading = false,
 
-  -- Connection transition tracking (for auto-discovery on reconnect)
-  wasConnected = false,
+  -- Telemetry transition tracking (for auto-discovery on reconnect)
+  hadTelemetry = false,
 }
 
 -- ============================================================================
@@ -135,7 +135,7 @@ function Protocol.reset()
   Protocol.loadQueue = {}
   Protocol.expectChunksRemain = -1
   Protocol.backgroundLoading = false
-  Protocol.wasConnected = false
+  Protocol.hadTelemetry = false
 end
 
 -- ============================================================================
@@ -157,8 +157,8 @@ function Protocol.pingDevices()
   )
 end
 
--- Check connection state from elrsFlags
-function Protocol.isConnected()
+-- Check if telemetry is being received from the RX (elrsFlags bit 1)
+function Protocol.hasTelemetry()
   return bit32.btest(Protocol.elrsFlags, 1)
 end
 
@@ -742,12 +742,12 @@ function Protocol.poll()
 end
 
 function Protocol.tick()
-  -- Ping on connection transition (device may have changed)
-  local connected = Protocol.isConnected()
-  if connected and not Protocol.wasConnected then
+  -- Ping on telemetry transition (device may have changed)
+  local hasTelemetry = Protocol.hasTelemetry()
+  if hasTelemetry and not Protocol.hadTelemetry then
     Protocol.pingDevices()
   end
-  Protocol.wasConnected = connected
+  Protocol.hadTelemetry = hasTelemetry
 
   local time = getTime()
   -- Periodic ping for initial device discovery

src/SCRIPTS/TOOLS/ExpressLRS/ui/lcd.lua

@@ -419,7 +419,7 @@ function UI.drawTitle()
   local barHeight = 9
   local goodBadPkt = ""
   if Protocol.receivedPackets then
-    local state = Protocol.isConnected() and "C" or "-"
+    local state = Protocol.hasTelemetry() and "C" or "-"
     goodBadPkt = string.format("%u/%u   %s", Protocol.lostPackets, Protocol.receivedPackets, state)
   end
 

src/SCRIPTS/TOOLS/ExpressLRS/ui/lvgl.lua

@@ -664,7 +664,7 @@ function UI.getSubtitle()
 
   local subtitle = ""
   if Protocol.receivedPackets then
-    local state = Protocol.isConnected() and "Connected" or "No link"
+    local state = Protocol.hasTelemetry() and "Telemetry OK" or "No telemetry"
     subtitle = string.format("%u/%u • %s", Protocol.lostPackets, Protocol.receivedPackets, state)
   end
 

src/WIDGETS/ELRSTelemetry/loadable.lua

@@ -94,8 +94,8 @@ function Telemetry.statusText()
   if not crsf.hasCrsfModule() then
     return "No CRSF module"
   end
-  if not crsf.rxConnected then
-    return "No RX"
+  if not crsf.hasTelemetry then
+    return "No telemetry"
   end
   if crsf.modelMismatch then
     return "Model Mismatch"
@@ -127,7 +127,7 @@ end
 
 --- Get RF mode string from device info.
 function Telemetry.getRfModeStr(rfmd)
-  if not crsf.rxConnected or rfmd == nil then
+  if not crsf.hasTelemetry or rfmd == nil then
     return ""
   end
   local mod = crsf.deviceInfo
@@ -170,7 +170,7 @@ end
 
 --- Range percentage + RSSI text (e.g. "Range 69% -90dBm").
 function Telemetry.signalText()
-  if not crsf.rxConnected then
+  if not crsf.hasTelemetry then
     return ""
   end
   local tlm = Telemetry.readLink()
@@ -188,7 +188,7 @@ function Telemetry.rfDetailText()
   local tlm = Telemetry.readLink()
   local mode = Telemetry.getRfModeStr(tlm.rfmd)
   local parts = { mode }
-  if crsf.rxConnected and tlm.tpwr then
+  if crsf.hasTelemetry and tlm.tpwr then
     parts[#parts + 1] = table.concat({ tostring(tlm.tpwr), "mW" })
   end
   return table.concat(parts, " ")
@@ -351,8 +351,8 @@ local function buildFullScreen()
       if not Telemetry.hasModule() then
         return "No CRSF module"
       end
-      if not crsf.rxConnected then
-        return "No RX Connected"
+      if not crsf.hasTelemetry then
+        return "No telemetry"
       end
       if crsf.modelMismatch then
         return "Model Mismatch"
@@ -413,15 +413,15 @@ local function buildFullScreen()
   end)
 
   createDisplayRow(fields, "Link Quality", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
     return table.concat({ tostring(tlm.rqly or 0), "%" })
   end)
 
   createDisplayRow(fields, "RSSI 1", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
@@ -432,7 +432,7 @@ local function buildFullScreen()
   end)
 
   createDisplayRow(fields, "RSSI 2", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
@@ -448,7 +448,7 @@ local function buildFullScreen()
   end)
 
   createDisplayRow(fields, "Active Antenna", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
@@ -459,7 +459,7 @@ local function buildFullScreen()
   end)
 
   createDisplayRow(fields, "Range", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
@@ -471,7 +471,7 @@ local function buildFullScreen()
   createSectionHeader(fields, "Power")
 
   createDisplayRow(fields, "TX Power", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
@@ -482,7 +482,7 @@ local function buildFullScreen()
   end)
 
   createDisplayRow(fields, "Power Index", function()
-    if not crsf.rxConnected then
+    if not crsf.hasTelemetry then
       return "--"
     end
     local tlm = Telemetry.readLink()
@@ -586,7 +586,7 @@ function wgt.refresh(_event, _touchState)
   wgt.background()
 
   -- Update diversity detection each tick
-  if crsf.rxConnected then
+  if crsf.hasTelemetry then
     local tlm = Telemetry.readLink()
     Telemetry.updateDiversity(tlm.ant)
   end

src/WIDGETS/ELRSTelemetry/ui/hd.lua

@@ -38,7 +38,7 @@ local function heroColorMismatch()
 end
 
 local function detailColor()
-  if not crsf.rxConnected then
+  if not crsf.hasTelemetry then
     return COLOR_THEME_SECONDARY1
   end
   return Telemetry.rangeColor(Telemetry.smoothRng or 0)

src/WIDGETS/ELRSTelemetry/ui/portrait.lua

@@ -38,7 +38,7 @@ local function heroColorMismatch()
 end
 
 local function detailColor()
-  if not crsf.rxConnected then
+  if not crsf.hasTelemetry then
     return COLOR_THEME_SECONDARY1
   end
   return Telemetry.rangeColor(Telemetry.smoothRng or 0)

src/WIDGETS/ELRSTelemetry/ui/sd.lua

@@ -38,7 +38,7 @@ local function heroColorMismatch()
 end
 
 local function detailColor()
-  if not crsf.rxConnected then
+  if not crsf.hasTelemetry then
     return COLOR_THEME_SECONDARY1
   end
   return Telemetry.rangeColor(Telemetry.smoothRng or 0)

src/WIDGETS/ELRSTelemetry/ui/sd_tall.lua

@@ -39,7 +39,7 @@ local function heroColorMismatch()
 end
 
 local function detailColor()
-  if not crsf.rxConnected then
+  if not crsf.hasTelemetry then
     return COLOR_THEME_SECONDARY1
   end
   return Telemetry.rangeColor(Telemetry.smoothRng or 0)