Skip to content

Commit c96d141

Browse files
authored
Merge pull request #247 from American-Institutes-for-Research/HEA-196/sub-national-seasons
Support sub-national seasons using zone-specific aliases - see HEA-196
2 parents 1527338 + 0fe4ab5 commit c96d141

6 files changed

Lines changed: 320 additions & 94 deletions

File tree

apps/metadata/admin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ class SeasonAdmin(admin.ModelAdmin):
145145
*translation_fields("name"),
146146
"season_type",
147147
"purpose",
148+
"aliases",
148149
)
149150
list_filter = (
150151
("country", admin.RelatedOnlyFieldListFilter),

apps/metadata/lookups.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ def prepare_lookup_df(self) -> pd.DataFrame:
6262
extra_dfs = []
6363
for country in all_countries:
6464
country_df = df[df["country_id"] == country]
65-
null_purpose_rows = country_df[country_df["purpose"].isnull()]
65+
# Purpose isn't a foreign key, and has blank=True, null=True, so there may be rows with a null purpose
66+
# and others with purpose=="".
67+
null_purpose_rows = country_df[country_df["purpose"].isna() | (country_df["purpose"] == "")]
6668
for purpose in all_purposes:
6769
# Only add duplicate rows for purposes that aren't already defined for this country
6870
if purpose not in country_df["purpose"].unique():

0 commit comments

Comments
 (0)