fix: Handle iOS scheme with space (#150)

* fix: handle scheme with space

* ci: specify node version

* ci: try node 16

* fix: test on iPhone 14

* Revert "fix: test on iPhone 14"

This reverts commit d5cc3d4.

* chore: add changeset

Author: robwalkerco

.changeset/thick-singers-behave.md

@@ -0,0 +1,5 @@
+---
+'react-native-owl': patch
+---
+
+Handle iOS scheme with space

.github/workflows/demo-app.yml

@@ -7,6 +7,10 @@ jobs:
     runs-on: macos-11
 
     steps:
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
       - uses: actions/checkout@v2
 
       - name: Get Runner Information

.github/workflows/demo-expo-app.yml

@@ -10,6 +10,10 @@ jobs:
     if: ${{ false }}
 
     steps:
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
       - uses: actions/checkout@v2
 
       - name: Get Runner Information

.github/workflows/run-tests.yml

@@ -10,6 +10,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
       - uses: actions/checkout@v2
 
       - name: Get yarn cache directory path

lib/cli/build.test.ts

@@ -35,6 +35,26 @@ describe('build.ts', () => {
       );
     });
 
+    it('builds an iOS project with scheme with a space in it', async () => {
+      const config: Config & { ios: { env: ConfigEnv } } = {
+        ios: {
+          workspace: 'ios/RNDemo.xcworkspace',
+          scheme: 'Demo With Space',
+          configuration: 'Debug',
+          device: 'iPhone Simulator',
+          env: { ENTRY_FILE },
+        },
+      };
+
+      await buildIOS(config, logger);
+
+      expect(execMock).toHaveBeenCalledTimes(1);
+      expect(execMock).toHaveBeenCalledWith(
+        `xcodebuild -workspace ios/RNDemo.xcworkspace -scheme Demo\\ With\\ Space -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build`,
+        { stdio: 'inherit', env: { ENTRY_FILE } }
+      );
+    });
+
     it('builds an iOS project with workspace/scheme - with the quiet arg', async () => {
       const config: Config & { ios: { env: ConfigEnv } } = {
         ios: {

lib/cli/build.ts

@@ -17,7 +17,7 @@ export const buildIOS = async (
     : [
         `xcodebuild`,
         `-workspace ${config.ios?.workspace}`,
-        `-scheme ${config.ios?.scheme}`,
+        `-scheme ${config.ios?.scheme?.split(' ').join('\\ ')}`,
         `-configuration ${config.ios?.configuration}`,
         `-sdk iphonesimulator`,
         `-derivedDataPath ios/build`,