fwk: input_module: Allow full-width module in any location

Fixes: fwk-main        20999ff
Fixes: fwk-tulip-29169 d98acb5

The existing logic goes through the top-row pogos from left to right and
skips the ones that are covered.
This does not work with a full-width inputmodule that is not connected to the left-most pogo.
I didn't consider that the full-width module can have its connector on any of the pogos, because all of our official modules have them on the very left of the module.
Customers are building modules and reporting issues.

Add another loop that goes through every connector and returns true if
a full-width module is connected to any pogo.

To keep the logic simple, I also moved the touchpad check to the
beginning, then the last loop can just return.

> framework_tool --inputdeck
Chassis Closed:   true
Input Deck State: On
Touchpad present: true
SLEEP# GPIO high: true
Positions:
  Pos 0: Disconnected
  Pos 1: FullWidth
  Pos 2: Disconnected
  Pos 3: Disconnected
  Pos 4: Disconnected

ec:~> inputdeck
Deck state: ON
    C-Deck status 0 = 15 2813 mV [X - -    - -] [Disconnected]
    C-Deck status 1 =  6  907 mV [- X -    - -] [Generic Full Width]
    C-Deck status 2 = 15 2813 mV [- - X    - -] [Disconnected]
    C-Deck status 3 = 15 2813 mV [- - -    X -] [Disconnected]
    C-Deck status 4 = 15 2813 mV [- - -    - X] [Disconnected]
    C-Deck status 5 = 13 2505 mV [Touchpad    ] [Touchpad]
    C-Deck status 6 = 15 2813 mV [Toprow disc.] [Disconnected]
    C-Deck status 7 = 15 2813 mV [Hubboard    ] [Disconnected]
Input module Overcurrent Events: 0

BRANCH=fwk-tulip-29169
BUG=Full-width input module connected not to left-most pogo does not enable input deck power
TEST=Keyboard/touchpad works with full-width inputmodule connected
TEST=`framework_tool --inputdeck`
TEST=EC console `inputdeck` command

Signed-off-by: Daniel Schaefer <dhs@frame.work>

Author: JohnAZoidberg

zephyr/program/framework/lotus/src/input_module.c

@@ -123,15 +123,33 @@ bool input_deck_is_fully_populated(void)
 {
 	int i;
 
+	/* All modules connect through the hubboard */
 	if (hub_board_id[HUBBOARD] == INPUT_MODULE_SHORT ||
 		hub_board_id[HUBBOARD] == INPUT_MODULE_DISCONNECTED) {
 		return false;
 	}
+
+	/* Touchpad is either present or not */
+	if (hub_board_id[TOUCHPAD] != INPUT_MODULE_TOUCHPAD) {
+		return false;
+	}
+
+	/* The full-width module covers the whole input deck top row,
+	 * but unlike our other modules the connector does not have to be at
+	 * the left edge of the module - it can be anywhere.
+	 */
+	for (i = 0; i <= TOP_ROW_4; i++) {
+		if (hub_board_id[i] == INPUT_MODULE_FULL_WIDTH)
+			return true;
+	}
+
+	/* Go through the input deck top row from left to right,
+	 * when detecting a module, jump over all empty slots that the module covers.
+	 * If the end is reached, the deck is fully covered.
+	 * If any slot after a module is empty, something is missing.
+	 */
 	for (i = 0; i <= TOP_ROW_4;) {
 		switch (hub_board_id[i]) {
-		case INPUT_MODULE_FULL_WIDTH:
-			i += 5;
-			break;
 		case INPUT_MODULE_GENERIC_A:
 		case INPUT_MODULE_KEYBOARD_A:
 			i += 3;
@@ -148,10 +166,6 @@ bool input_deck_is_fully_populated(void)
 		}
 	}
 
-	if (hub_board_id[TOUCHPAD] != INPUT_MODULE_TOUCHPAD) {
-		return false;
-	}
-
 	return true;
 }