Skip to content

Commit e889550

Browse files
Josh-TsaiJohnAZoidberg
authored andcommitted
fwk/sunflower: enable KEYBOARD_STRICT_DEBOUNCE
Enable keyboard strict debounce to eliminate the ghost key issue. KEYBOARD_STRICT_DEBOUNCE's comment says we need to make debounce up and down the same, so we do that as well. BRANCH=fwk-sunflower-26784 BUG=https://app.clickup.com/t/86et5v7wg TEST=hold the space key and then press "space" and "1" key will not print the ghost key Signed-off-by: Josh Tsai <Josh_Tsai@compal.com>
1 parent 1414c33 commit e889550

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

zephyr/program/framework/sunflower/project.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ CONFIG_PLATFORM_EC_FAN_RPM_CUSTOM=n
3333

3434
# Keyboard
3535
CONFIG_PLATFORM_EC_KEYBOARD_CUSTOMIZATION=y
36+
CONFIG_PLATFORM_EC_KEYBOARD_STRICT_DEBOUNCE=y
3637
CONFIG_PLATFORM_KEYBOARD_SCANCODE_CALLBACK=y
3738
CONFIG_PLATFORM_EC_IOEX_IT8801=y
3839

zephyr/program/framework/sunflower/src/keyboard_customization.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ DECLARE_HOOK(HOOK_INIT_EARLY, disable_keyscan, HOOK_PRIO_DEFAULT);
4747
__override struct keyboard_scan_config keyscan_config = {
4848
.output_settle_us = 80,
4949
.debounce_down_us = 20 * MSEC,
50-
.debounce_up_us = 30 * MSEC,
50+
.debounce_up_us = 20 * MSEC,
5151
.scan_period_us = 3 * MSEC,
5252
.min_post_scan_delay_us = 1000,
5353
.poll_timeout_us = 100 * MSEC,

0 commit comments

Comments
 (0)