Skip to content

Commit f6f3791

Browse files
fwk: Remove unimplemented FN+S
There is no need for the FN+S shortcut. The PRT SCR key works as sysrq. This is the same as on QMK with `KC_PRINT_SCREEN` ``` > sudo libinput debug-events --show-keycodes | grep KEYBOARD_KEY -event2 KEYBOARD_KEY +4.295s KEY_SYSRQ (99) pressed event2 KEYBOARD_KEY +0.067s KEY_SYSRQ (99) released ``` BUG=Customer was asking why FN+S wasn't working. BRANCH=fwk-main TEST=`zmake build marigold` Signed-off-by: Daniel Schaefer <dhs@frame.work> Co-authored-by: Quin Chou <chc@frame.work> (cherry picked from commit 281d6ba)
1 parent d2a654b commit f6f3791

1 file changed

Lines changed: 1 addition & 10 deletions

File tree

zephyr/program/framework/src/keyboard_customization_13.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,7 @@ int hotkey_F1_F12(uint16_t *key_code, uint16_t fn, int8_t pressed)
323323
}
324324
break;
325325
case SCANCODE_F11:
326-
/*
327-
* TODO this might need an
328-
* extra key combo of:
329-
* 0xE012 0xE07C to simulate
330-
* PRINT_SCREEN
331-
*/
326+
/* Print screen / SYSRQ */
332327
if (fn_table_media_set(pressed, KB_FN_F11))
333328
*key_code = 0xE07C;
334329
break;
@@ -357,10 +352,6 @@ int hotkey_special_key(uint16_t *key_code, int8_t pressed)
357352
if (fn_table_set(pressed, KB_FN_K))
358353
*key_code = SCANCODE_SCROLL_LOCK;
359354
break;
360-
case SCANCODE_S: /* TODO: SYSRQ */
361-
/*if (!fn_table_set(pressed, KB_FN_S))*/
362-
363-
break;
364355
case SCANCODE_LEFT: /* HOME */
365356
if (fn_table_set(pressed, KB_FN_LEFT))
366357
*key_code = 0xe06c;

0 commit comments

Comments
 (0)