Skip to content

Commit 59b149b

Browse files
committed
Safely parse retimer version bytes
Don't implicitly panic if there are not enough bytes returned Signed-off-by: Daniel Schaefer <dhs@frame.work>
1 parent df304f2 commit 59b149b

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

  • framework_lib/src/commandline

framework_lib/src/commandline/mod.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -714,10 +714,11 @@ fn print_versions(ec: &CrosEc) {
714714
Ok(None) => {}
715715
Ok(Some(ver)) => {
716716
println!("Parade Retimers");
717-
println!(
718-
" dGPU: {:X}.{:X}.{:X}.{:X}",
719-
ver[0], ver[1], ver[2], ver[3]
720-
);
717+
if let [a, b, c, d, ..] = ver.as_slice() {
718+
println!(" dGPU: {:X}.{:X}.{:X}.{:X}", a, b, c, d);
719+
} else {
720+
println!(" dGPU: Unknown");
721+
}
721722
}
722723
_err => {
723724
// Only Framework 16 has dGPU support (which has Parade Retimer)

0 commit comments

Comments
 (0)