Add --validate-gpu-descriptor command

To purely validate that the current EEPROM matches a local file and
print the diff if not.

Signed-off-by: Daniel Schaefer <dhs@frame.work>

Author: JohnAZoidberg

framework_lib/src/commandline/clap_std.rs

@@ -309,6 +309,10 @@ struct ClapCli {
     #[arg(long)]
     dump_gpu_descriptor_file: Option<std::path::PathBuf>,
 
+    /// File to validate the gpu EEPROM against
+    #[arg(long)]
+    validate_gpu_descriptor_file: Option<std::path::PathBuf>,
+
     /// Show NVIDIA GPU information (Framework 16 only)
     #[arg(long)]
     nvidia: bool,
@@ -564,6 +568,9 @@ pub fn parse(args: &[String]) -> Cli {
         dump_gpu_descriptor_file: args
             .dump_gpu_descriptor_file
             .map(|x| x.into_os_string().into_string().unwrap()),
+        validate_gpu_descriptor_file: args
+            .validate_gpu_descriptor_file
+            .map(|x| x.into_os_string().into_string().unwrap()),
         nvidia: args.nvidia,
         host_command,
     }

framework_lib/src/commandline/mod.rs

@@ -227,6 +227,7 @@ pub struct Cli {
     pub flash_gpu_descriptor: Option<(u8, String)>,
     pub flash_gpu_descriptor_file: Option<String>,
     pub dump_gpu_descriptor_file: Option<String>,
+    pub validate_gpu_descriptor_file: Option<String>,
     pub nvidia: bool,
     // UEFI only
     pub allupdate: bool,
@@ -1827,6 +1828,25 @@ pub fn run_with_args(args: &Cli, _allupdate: bool) -> i32 {
             println!("Dumping to {}", dump_path);
         }
         dump_dgpu_eeprom(&ec, dump_path);
+    } else if let Some(validate_path) = &args.validate_gpu_descriptor_file {
+        #[cfg(feature = "uefi")]
+        let data: Option<Vec<u8>> = crate::fw_uefi::fs::shell_read_file(validate_path);
+        #[cfg(not(feature = "uefi"))]
+        let data = match fs::read(validate_path) {
+            Ok(data) => Some(data),
+            Err(e) => {
+                println!("Error {:?}", e);
+                None
+            }
+        };
+        if let Some(data) = data {
+            println!("Validating GPU Descriptor against {}", validate_path);
+            match ec.validate_gpu_descriptor(&data) {
+                Ok(true) => println!("  Validation passed"),
+                Ok(false) => println!("  Validation FAILED: read-back mismatch"),
+                Err(err) => println!("  Validation error: {:?}", err),
+            }
+        }
     }
 
     0

framework_lib/src/commandline/uefi.rs

@@ -101,6 +101,7 @@ pub fn parse(args: &[String]) -> Cli {
         flash_gpu_descriptor: None,
         flash_gpu_descriptor_file: None,
         dump_gpu_descriptor_file: None,
+        validate_gpu_descriptor_file: None,
         allupdate: false,
         info: false,
         meinfo: None,
@@ -859,6 +860,14 @@ pub fn parse(args: &[String]) -> Cli {
                 None
             };
             found_an_option = true;
+        } else if arg == "--validate-gpu-descriptor-file" {
+            cli.validate_gpu_descriptor_file = if args.len() > i + 1 {
+                Some(args[i + 1].clone())
+            } else {
+                println!("Need to provide a value for --validate_gpu_descriptor_file. PATH");
+                None
+            };
+            found_an_option = true;
         }
     }