use correct http code

RichardJECooke · RichardJECooke · commit cd180bae4838 · 2023-09-12T11:51:08.000+02:00
diff --git a/complete-application/services/hasRole.js b/complete-application/services/hasRole.js
@@ -4,7 +4,7 @@ function hasRole(roles) {
   return (req, res, next) => {
     const decodedToken = jose.decodeJwt(req.cookies['app.at']);
     if (roles.some((role) => decodedToken.roles.includes(role))) return next();
-    res.status(500);
+    res.status(403);
     res.send({ error: `You do not have a role with permissions to do this.` });
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ function hasRole(roles) {`
`4`	`4`	`return (req, res, next) => {`
`5`	`5`	`const decodedToken = jose.decodeJwt(req.cookies['app.at']);`
`6`	`6`	`if (roles.some((role) => decodedToken.roles.includes(role))) return next();`
`7`		`- res.status(500);`
	`7`	`+ res.status(403);`
`8`	`8`	res.send({ error: `You do not have a role with permissions to do this.` });
`9`	`9`	`}`
`10`	`10`	`}`