Skip to content

Commit 1de67a3

Browse files
ceggers-arriwsakernel
authored andcommitted
i2c: imx: Check for I2SR_IAL after every byte
Arbitration Lost (IAL) can happen after every single byte transfer. If arbitration is lost, the I2C hardware will autonomously switch from master mode to slave. If a transfer is not aborted in this state, consecutive transfers will not be executed by the hardware and will timeout. Signed-off-by: Christian Eggers <ceggers@arri.de> Tested (not extensively) on Vybrid VF500 (Toradex VF50): Tested-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Cc: stable@vger.kernel.org Signed-off-by: Wolfram Sang <wsa@kernel.org>
1 parent 384a956 commit 1de67a3

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/i2c/busses/i2c-imx.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,16 @@ static int i2c_imx_trx_complete(struct imx_i2c_struct *i2c_imx, bool atomic)
490490
dev_dbg(&i2c_imx->adapter.dev, "<%s> Timeout\n", __func__);
491491
return -ETIMEDOUT;
492492
}
493+
494+
/* check for arbitration lost */
495+
if (i2c_imx->i2csr & I2SR_IAL) {
496+
dev_dbg(&i2c_imx->adapter.dev, "<%s> Arbitration lost\n", __func__);
497+
i2c_imx_clear_irq(i2c_imx, I2SR_IAL);
498+
499+
i2c_imx->i2csr = 0;
500+
return -EAGAIN;
501+
}
502+
493503
dev_dbg(&i2c_imx->adapter.dev, "<%s> TRX complete\n", __func__);
494504
i2c_imx->i2csr = 0;
495505
return 0;

0 commit comments

Comments
 (0)