Skip to content

Commit 2874211

Browse files
Dan Carpentermstsirkin
authored andcommitted
vdpa/mlx5: Fix pointer math in mlx5_vdpa_get_config()
There is a pointer math bug here so if "offset" is non-zero then this will copy memory from beyond the end of the array. Fixes: 1a86b37 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20200808093241.GB115053@mwanda Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Eli Cohen <elic@nvidia.com> Cc: Jason Wang <jasowang@redhat.com>; Parav Pandit <parav@mellanox.com>; virtualization@lists.linux-foundation.org; linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org Fixes: 1a86b37 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
1 parent f31231b commit 2874211

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/vdpa/mlx5/net/mlx5_vnet.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1757,7 +1757,7 @@ static void mlx5_vdpa_get_config(struct vdpa_device *vdev, unsigned int offset,
17571757
struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
17581758

17591759
if (offset + len < sizeof(struct virtio_net_config))
1760-
memcpy(buf, &ndev->config + offset, len);
1760+
memcpy(buf, (u8 *)&ndev->config + offset, len);
17611761
}
17621762

17631763
static void mlx5_vdpa_set_config(struct vdpa_device *vdev, unsigned int offset, const void *buf,

0 commit comments

Comments
 (0)