KVM: selftests: Always clear dirty bitmap after iteration

xzpeter · bonzini · commit 3031e0288e60 · 2020-11-08T06:03:11.000-05:00
We used not to clear the dirty bitmap before because KVM_GET_DIRTY_LOG
would overwrite it the next time it copies the dirty log onto it.
In the upcoming dirty ring tests we'll start to fetch dirty pages from
a ring buffer, so no one is going to clear the dirty bitmap for us.

Reviewed-by: Andrew Jones &lt;drjones@redhat.com&gt;
Signed-off-by: Peter Xu &lt;peterx@redhat.com&gt;
Message-Id: &lt;20201001012228.5916-1-peterx@redhat.com&gt;
Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c
@@ -195,7 +195,7 @@ static void vm_dirty_log_verify(enum vm_guest_mode mode, unsigned long *bmap)
 				    page);
 		}
 
-		if (test_bit_le(page, bmap)) {
+		if (test_and_clear_bit_le(page, bmap)) {
 			host_dirty_count++;
 			/*
 			 * If the bit is set, the value written onto

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ static void vm_dirty_log_verify(enum vm_guest_mode mode, unsigned long *bmap)`
`195`	`195`	`page);`
`196`	`196`	`}`
`197`	`197`
`198`		`- if (test_bit_le(page, bmap)) {`
	`198`	`+ if (test_and_clear_bit_le(page, bmap)) {`
`199`	`199`	`host_dirty_count++;`
`200`	`200`	`/*`
`201`	`201`	`* If the bit is set, the value written onto`