ACPI: configfs: Add missing config_item_put() to fix refcount leak

guohanjun · gregkh · commit 3b224e0d4322 · 2020-11-05T11:51:33.000+01:00
commit 9a2e849 upstream. config_item_put() should be called in the drop_item callback, to decrement refcount for the config item. Fixes: 772bf1e ("ACPI: configfs: Unload SSDT on configfs entry removal") Signed-off-by: Hanjun Guo <guohanjun@huawei.com> [ rjw: Subject edit ] Cc: 4.13+ <stable@vger.kernel.org> # 4.13+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_configfs.c
@@ -228,6 +228,7 @@ static void acpi_table_drop_item(struct config_group *group,
 
 	ACPI_INFO(("Host-directed Dynamic ACPI Table Unload"));
 	acpi_unload_table(table->index);
+	config_item_put(cfg);
 }
 
 static struct configfs_group_operations acpi_table_group_ops = {

Original file line number	Diff line number	Diff line change
`@@ -228,6 +228,7 @@ static void acpi_table_drop_item(struct config_group *group,`
`228`	`228`
`229`	`229`	`ACPI_INFO(("Host-directed Dynamic ACPI Table Unload"));`
`230`	`230`	`acpi_unload_table(table->index);`
	`231`	`+ config_item_put(cfg);`
`231`	`232`	`}`
`232`	`233`
`233`	`234`	`static struct configfs_group_operations acpi_table_group_ops = {`