Skip to content

Commit 3beb9be

Browse files
Zhang Changzhongkuba-moo
authored andcommitted
qlcnic: fix error return code in qlcnic_83xx_restart_hw()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 3ced0a8 ("qlcnic: Add support to run firmware POST") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Link: https://lore.kernel.org/r/1605248186-16013-1-git-send-email-zhangchangzhong@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent cfbaa8b commit 3beb9be

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2231,7 +2231,8 @@ static int qlcnic_83xx_restart_hw(struct qlcnic_adapter *adapter)
22312231

22322232
/* Boot either flash image or firmware image from host file system */
22332233
if (qlcnic_load_fw_file == 1) {
2234-
if (qlcnic_83xx_load_fw_image_from_host(adapter))
2234+
err = qlcnic_83xx_load_fw_image_from_host(adapter);
2235+
if (err)
22352236
return err;
22362237
} else {
22372238
QLC_SHARED_REG_WR32(adapter, QLCNIC_FW_IMG_VALID,

0 commit comments

Comments
 (0)