Skip to content

Commit 5802528

Browse files
ebiggersgregkh
authored andcommitted
ext4: fix leaking sysfs kobject after failed mount
commit cb8d53d upstream. ext4_unregister_sysfs() only deletes the kobject. The reference to it needs to be put separately, like ext4_put_super() does. This addresses the syzbot report "memory leak in kobject_set_name_vargs (3)" (https://syzkaller.appspot.com/bug?extid=9f864abad79fae7c17e1). Reported-by: syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com Fixes: 72ba745 ("ext4: release sysfs kobject when failing to enable quotas on mount") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers <ebiggers@google.com> Link: https://lore.kernel.org/r/20200922162456.93657-1-ebiggers@kernel.org Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d43b468 commit 5802528

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/ext4/super.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4872,6 +4872,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
48724872

48734873
failed_mount8:
48744874
ext4_unregister_sysfs(sb);
4875+
kobject_put(&sbi->s_kobj);
48754876
failed_mount7:
48764877
ext4_unregister_li_request(sb);
48774878
failed_mount6:

0 commit comments

Comments
 (0)