Skip to content

Commit 6bfd875

Browse files
uudiingregkh
authored andcommitted
scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()
[ Upstream commit bbf2d06 ] In the case of a failed retry, a positive value EIO is returned here. I think this is a typo error. It is necessary to return an error value. [mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up to be consistent] Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com Fixes: 0691094 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion") Cc: Quinn Tran <quinn.tran@cavium.com> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent e66701f commit 6bfd875

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/qla2xxx/qla_target.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha,
56685668
/* found existing exchange */
56695669
qpair->retry_term_cnt++;
56705670
if (qpair->retry_term_cnt >= 5) {
5671-
rc = EIO;
5671+
rc = -EIO;
56725672
qpair->retry_term_cnt = 0;
56735673
ql_log(ql_log_warn, vha, 0xffff,
56745674
"Unable to send ABTS Respond. Dumping firmware.\n");

0 commit comments

Comments
 (0)