Skip to content

Commit 8e4c309

Browse files
saschahaueraxboe
authored andcommitted
ata: sata_nv: Fix retrieving of active qcs
ata_qc_complete_multiple() has to be called with the tags physically active, that is the hw tag is at bit 0. ap->qc_active has the same tag at bit ATA_TAG_INTERNAL instead, so call ata_qc_get_active() to fix that up. This is done in the vein of 8385d75 ("libata: Fix retrieving of active qcs"). Fixes: 28361c4 ("libata: add extra internal command") Tested-by: Pali Rohár <pali@kernel.org> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 94bd571 commit 8e4c309

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/ata/sata_nv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2100,7 +2100,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
21002100
pp->dhfis_bits &= ~done_mask;
21012101
pp->dmafis_bits &= ~done_mask;
21022102
pp->sdbfis_bits |= done_mask;
2103-
ata_qc_complete_multiple(ap, ap->qc_active ^ done_mask);
2103+
ata_qc_complete_multiple(ap, ata_qc_get_active(ap) ^ done_mask);
21042104

21052105
if (!ap->qc_active) {
21062106
DPRINTK("over\n");

0 commit comments

Comments
 (0)