Skip to content

Commit 93be526

Browse files
logostkuba-moo
authored andcommitted
qed: fix ILT configuration of SRC block
The code refactoring of ILT configuration was not complete, the old unused variables were used for the SRC block. That could lead to the memory corruption by HW when rx filters are configured. This patch completes that refactoring. Fixes: 8a52bba (qed: Debug feature: ilt and mdump) Signed-off-by: Igor Russkikh <irusskikh@marvell.com> Signed-off-by: Ariel Elior <aelior@marvell.com> Signed-off-by: Dmitry Bogdanov <dbogdanov@marvell.com> Link: https://lore.kernel.org/r/20201116132944.2055-1-dbogdanov@marvell.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e33de7c commit 93be526

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

drivers/net/ethernet/qlogic/qed/qed_cxt.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1647,9 +1647,9 @@ static void qed_src_init_pf(struct qed_hwfn *p_hwfn)
16471647
ilog2(rounded_conn_num));
16481648

16491649
STORE_RT_REG_AGG(p_hwfn, SRC_REG_FIRSTFREE_RT_OFFSET,
1650-
p_hwfn->p_cxt_mngr->first_free);
1650+
p_hwfn->p_cxt_mngr->src_t2.first_free);
16511651
STORE_RT_REG_AGG(p_hwfn, SRC_REG_LASTFREE_RT_OFFSET,
1652-
p_hwfn->p_cxt_mngr->last_free);
1652+
p_hwfn->p_cxt_mngr->src_t2.last_free);
16531653
}
16541654

16551655
/* Timers PF */

drivers/net/ethernet/qlogic/qed/qed_cxt.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,9 +326,6 @@ struct qed_cxt_mngr {
326326

327327
/* SRC T2 */
328328
struct qed_src_t2 src_t2;
329-
u32 t2_num_pages;
330-
u64 first_free;
331-
u64 last_free;
332329

333330
/* total number of SRQ's for this hwfn */
334331
u32 srq_count;

0 commit comments

Comments
 (0)