Skip to content

Commit 9443f2c

Browse files
Lee Jonesthierryreding
authored andcommitted
pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
'duty' here is an unsigned int, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
1 parent b8fb642 commit 9443f2c

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/pwm/pwm-bcm-iproc.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm,
143143
value = rate * state->duty_cycle;
144144
duty = div64_u64(value, div);
145145

146-
if (period < IPROC_PWM_PERIOD_MIN ||
147-
duty < IPROC_PWM_DUTY_CYCLE_MIN)
146+
if (period < IPROC_PWM_PERIOD_MIN)
148147
return -EINVAL;
149148

150149
if (period <= IPROC_PWM_PERIOD_MAX &&

0 commit comments

Comments
 (0)