Commit 98025bc
ibmvnic: notify peers when failover and migration happen
Commit 61d3e1d ("ibmvnic: Remove netdev notify for failover resets")
excluded the failover case for notify call because it said
netdev_notify_peers() can cause network traffic to stall or halt.
Current testing does not show network traffic stall
or halt because of the notify call for failover event.
netdev_notify_peers may be used when a device wants to inform the
rest of the network about some sort of a reconfiguration
such as failover or migration.
It is unnecessary to call that in other events like
FATAL, NON_FATAL, CHANGE_PARAM, and TIMEOUT resets
since in those scenarios the hardware does not change.
If the driver must do a hard reset, it is necessary to notify peers.
Fixes: 61d3e1d ("ibmvnic: Remove netdev notify for failover resets")
Suggested-by: Brian King <brking@linux.vnet.ibm.com>
Suggested-by: Pradeep Satyanarayana <pradeeps@linux.vnet.ibm.com>
Signed-off-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: Lijun Pan <ljp@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>1 parent 8393597 commit 98025bc
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2074 | 2074 | | |
2075 | 2075 | | |
2076 | 2076 | | |
2077 | | - | |
| 2077 | + | |
| 2078 | + | |
2078 | 2079 | | |
2079 | 2080 | | |
2080 | 2081 | | |
| |||
2147 | 2148 | | |
2148 | 2149 | | |
2149 | 2150 | | |
| 2151 | + | |
| 2152 | + | |
| 2153 | + | |
2150 | 2154 | | |
2151 | 2155 | | |
2152 | 2156 | | |
| |||
0 commit comments