Skip to content

Commit a663e0d

Browse files
committed
thunderbolt: Fix memory leak if ida_simple_get() fails in enumerate_services()
The svc->key field is not released as it should be if ida_simple_get() fails so fix that. Fixes: 9aabb68 ("thunderbolt: Fix to check return value of ida_simple_get") Cc: stable@vger.kernel.org Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
1 parent 7342ca3 commit a663e0d

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/thunderbolt/xdomain.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -881,6 +881,7 @@ static void enumerate_services(struct tb_xdomain *xd)
881881

882882
id = ida_simple_get(&xd->service_ids, 0, 0, GFP_KERNEL);
883883
if (id < 0) {
884+
kfree(svc->key);
884885
kfree(svc);
885886
break;
886887
}

0 commit comments

Comments
 (0)