Skip to content

Commit d1c9ddc

Browse files
Tom Rixgregkh
authored andcommitted
video: fbdev: pvr2fb: initialize variables
[ Upstream commit 8e1ba47 ] clang static analysis reports this repesentative error pvr2fb.c:1049:2: warning: 1st function call argument is an uninitialized value [core.CallAndMessage] if (*cable_arg) ^~~~~~~~~~~~~~~ Problem is that cable_arg depends on the input loop to set the cable_arg[0]. If it does not, then some random value from the stack is used. A similar problem exists for output_arg. So initialize cable_arg and output_arg. Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 9745a32 commit d1c9ddc

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/video/fbdev/pvr2fb.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options)
10281028
if (!options || !*options)
10291029
return 0;
10301030

1031+
cable_arg[0] = output_arg[0] = 0;
1032+
10311033
while ((this_opt = strsep(&options, ","))) {
10321034
if (!*this_opt)
10331035
continue;

0 commit comments

Comments
 (0)