Skip to content

Commit dcef4a1

Browse files
Kai-Heng Fenggregkh
authored andcommitted
rtw88: pci: Power cycle device during shutdown
[ Upstream commit 44492e7 ] There are reports that 8822CE fails to work rtw88 with "failed to read DBI register" error. Also I have a system with 8723DE which freezes the whole system when the rtw88 is probing the device. According to [1], platform firmware may not properly power manage the device during shutdown. I did some expirements and putting the device to D3 can workaround the issue. So let's power cycle the device by putting the device to D3 at shutdown to prevent the issue from happening. [1] https://bugzilla.kernel.org/show_bug.cgi?id=206411#c9 BugLink: https://bugs.launchpad.net/bugs/1872984 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200928165508.20775-1-kai.heng.feng@canonical.com Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 5f845e5 commit dcef4a1

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • drivers/net/wireless/realtek/rtw88

drivers/net/wireless/realtek/rtw88/pci.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,6 +1599,8 @@ void rtw_pci_shutdown(struct pci_dev *pdev)
15991599

16001600
if (chip->ops->shutdown)
16011601
chip->ops->shutdown(rtwdev);
1602+
1603+
pci_set_power_state(pdev, PCI_D3hot);
16021604
}
16031605
EXPORT_SYMBOL(rtw_pci_shutdown);
16041606

0 commit comments

Comments
 (0)