Skip to content

Commit e9acf02

Browse files
Zhihao Chengwsakernel
authored andcommitted
i2c: qup: Fix error return code in qup_i2c_bam_schedule_desc()
Fix to return the error code from qup_i2c_change_state() instaed of 0 in qup_i2c_bam_schedule_desc(). Fixes: fbf9921 ("i2c: qup: Fix error handling") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Wolfram Sang <wsa@kernel.org>
1 parent b650545 commit e9acf02

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/i2c/busses/i2c-qup.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,8 @@ static int qup_i2c_bam_schedule_desc(struct qup_i2c_dev *qup)
801801
if (ret || qup->bus_err || qup->qup_err) {
802802
reinit_completion(&qup->xfer);
803803

804-
if (qup_i2c_change_state(qup, QUP_RUN_STATE)) {
804+
ret = qup_i2c_change_state(qup, QUP_RUN_STATE);
805+
if (ret) {
805806
dev_err(qup->dev, "change to run state timed out");
806807
goto desc_err;
807808
}

0 commit comments

Comments
 (0)