scsi: mvumi: Fix error return in mvumi_io_attach()

hiss2018 · gregkh · commit eed3b45a4c87 · 2020-10-29T10:12:13.000+01:00
[ Upstream commit 055f15a ] Return PTR_ERR() from the error handling case instead of 0. Link: https://lore.kernel.org/r/20200910123848.93649-1-jingxiangfeng@huawei.com Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
@@ -2425,6 +2425,7 @@ static int mvumi_io_attach(struct mvumi_hba *mhba)
 	if (IS_ERR(mhba->dm_thread)) {
 		dev_err(&mhba->pdev->dev,
 			"failed to create device scan thread\n");
+		ret = PTR_ERR(mhba->dm_thread);
 		mutex_unlock(&mhba->sas_discovery_mutex);
 		goto fail_create_thread;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2425,6 +2425,7 @@ static int mvumi_io_attach(struct mvumi_hba *mhba)`
`2425`	`2425`	`if (IS_ERR(mhba->dm_thread)) {`
`2426`	`2426`	`dev_err(&mhba->pdev->dev,`
`2427`	`2427`	`"failed to create device scan thread\n");`
	`2428`	`+ ret = PTR_ERR(mhba->dm_thread);`
`2428`	`2429`	`mutex_unlock(&mhba->sas_discovery_mutex);`
`2429`	`2430`	`goto fail_create_thread;`
`2430`	`2431`	`}`