Skip to content

Commit fa14e0a

Browse files
Thomas Bogendoerfergregkh
authored andcommitted
ibmveth: Fix use of ibmveth in a bridge.
[ Upstream commit 2ac8af0 ] The check for src mac address in ibmveth_is_packet_unsupported is wrong. Commit 6f22754 wanted to shut down messages for loopback packets, but now suppresses bridged frames, which are accepted by the hypervisor otherwise bridging won't work at all. Fixes: 6f22754 ("ibmveth: Detect unsupported packets before sending to the hypervisor") Signed-off-by: Michal Suchanek <msuchanek@suse.de> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> Link: https://lore.kernel.org/r/20201026104221.26570-1-msuchanek@suse.de Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d0cf5ae commit fa14e0a

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/net/ethernet/ibm/ibmveth.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported(struct sk_buff *skb,
10311031
ret = -EOPNOTSUPP;
10321032
}
10331033

1034-
if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) {
1035-
netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n");
1036-
netdev->stats.tx_dropped++;
1037-
ret = -EOPNOTSUPP;
1038-
}
1039-
10401034
return ret;
10411035
}
10421036

0 commit comments

Comments
 (0)