Skip to content

Commit fb738b9

Browse files
idoschkuba-moo
authored andcommitted
mlxsw: Fix firmware flashing
The commit cited below moved firmware flashing functionality from mlxsw_spectrum to mlxsw_core, but did not adjust the Kconfig dependencies. This makes it possible to have mlxsw_core as built-in and mlxfw as a module. The mlxfw code is therefore not reachable from mlxsw_core and firmware flashing fails: # devlink dev flash pci/0000:01:00.0 file mellanox/mlxsw_spectrum-13.2008.1310.mfa2 devlink answers: Operation not supported Fix by having mlxsw_core select mlxfw. Fixes: b79cb78 ("mlxsw: Move fw flashing code into core.c") Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reported-by: Vadim Pasternak <vadimp@nvidia.com> Tested-by: Vadim Pasternak <vadimp@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 1532b97 commit fb738b9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/net/ethernet/mellanox/mlxsw

drivers/net/ethernet/mellanox/mlxsw/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
config MLXSW_CORE
77
tristate "Mellanox Technologies Switch ASICs support"
88
select NET_DEVLINK
9+
select MLXFW
910
help
1011
This driver supports Mellanox Technologies Switch ASICs family.
1112

@@ -82,7 +83,6 @@ config MLXSW_SPECTRUM
8283
select GENERIC_ALLOCATOR
8384
select PARMAN
8485
select OBJAGG
85-
select MLXFW
8686
imply PTP_1588_CLOCK
8787
select NET_PTP_CLASSIFY if PTP_1588_CLOCK
8888
default m

0 commit comments

Comments
 (0)