when moving to newtonsoft, serialization and deserialization scheme changed, but was kept in certain parts, need to fix this

Author: GieziJo

Editor/SOVariant.cs

@@ -106,8 +106,17 @@ public void NotifyOverrideChangeInState(string name, bool isOverriden)
                     targetFieldInfo.GetValue(_target) == parentFieldInfo.GetValue(_parent))
                 {
                     object parentObject = parentFieldInfo.GetValue(_parent);
-                    object parentObjectCopy =
-                        Clone(parentObject);
+                    
+                    var jsonSettings = new Newtonsoft.Json.JsonSerializerSettings() {
+                        // Use this option
+                        //
+                        // to ignore reference looping option
+                        ReferenceLoopHandling = Newtonsoft.Json.ReferenceLoopHandling.Ignore,
+                        // Use this option when properties use an Interface as the type
+                        TypeNameHandling = Newtonsoft.Json.TypeNameHandling.All
+                    };
+                    var serialized = JsonConvert.SerializeObject(parentObject, jsonSettings);
+                    object parentObjectCopy = JsonConvert.DeserializeObject<object>(serialized, jsonSettings);
                     targetFieldInfo.SetValue(_target, parentObjectCopy);
                 }
             }
@@ -182,11 +191,13 @@ public void LoadData(T targetObject)
 
         private Tuple<string, T, List<string>, List<string>> ExtractData(string data)
         {
-            if(string.IsNullOrEmpty(data))
+            if(!CheckForDataString(data))
                 return new Tuple<string, T, List<string>, List<string>>(null, null, null, null);
             try
             {
-                string dataJson = JsonConvert.DeserializeObject<Dictionary<string, string>>(data)["SOVariantData"];
+                string dataJson = GetSOVariantData(data);
+                if(! CheckForDataString(dataJson))
+                    return new Tuple<string, T, List<string>, List<string>>(null, null, null, null);
                 Dictionary<string, string> containedData =
                     JsonConvert.DeserializeObject<Dictionary<string, string>>(dataJson);
 
@@ -224,10 +235,20 @@ private Tuple<string, T, List<string>, List<string>> ExtractData(string data)
                         return ExtractData(ReadUpdatedMetaFile(data));
                 }
             }
-
             return null;
         }
 
+        private static string GetSOVariantData(string data)
+        {
+            string dataJson = JsonConvert.DeserializeObject<Dictionary<string, string>>(data)["SOVariantData"];
+            return dataJson;
+        }
+
+        private bool CheckForDataString(string data)
+        {
+            return !string.IsNullOrEmpty(data) ;
+        }
+
         private List<string> DeserializeChildrenData(string data)
         {
             // byte[] childrenDataStream = data.Split(',').ToList().Select(source => byte.Parse(source)).ToArray();
@@ -353,6 +374,7 @@ private void PropagateValuesToChildren(T target, string targetGUID, ref List<str
 
         private void AddToChildrenData(AssetImporter importer, string newChild)
         {
+            Debug.Log(importer.userData);
             string[] data = importer.userData.Split('*');
             if (data.Length != 3)
             {
@@ -505,19 +527,5 @@ private string ReadUpdatedMetaFile(string oldData)
 
             return oldData;
         }
-        
-        private T Clone<T>(T source)
-        {
-            var jsonSettings = new Newtonsoft.Json.JsonSerializerSettings() {
-                // Use this option
-                //
-                // to ignore reference looping option
-                ReferenceLoopHandling = Newtonsoft.Json.ReferenceLoopHandling.Ignore,
-                // Use this option when properties use an Interface as the type
-                TypeNameHandling = Newtonsoft.Json.TypeNameHandling.All
-            };
-            var serialized = JsonConvert.SerializeObject(source, jsonSettings);
-            return JsonConvert.DeserializeObject<T>(serialized, jsonSettings);
-        }
     }
 }